Storage: DMFile supports read/write from S3. #6913

JinheLin · 2023-02-28T06:10:40Z

What problem does this PR solve?

Issue Number: ref #6827

What is changed and how it works?

This PR adds support for DMFiles reading and writing S3.
S3RandomAccessFile is similar to PosixRandomAccessFile. If you pass a S3 filename to DMFile::restore it will automatically read from S3.
S3WritableFile is similar to PosixWritableFile. Theoretically, like DMFile::restore, if you pass a S3 filename in DMFile::create it will automatically write to S3.
However, in order to ensure atomic visibility of DMFile, currently code DMFile is written to local disk and then uploaded to S3. It still need some adaptation to support writing to S3 directly.

TODO:

Support upload to S3 after code of DataStore merged.
Support file cache.
Merge small column data files before upload to S3.
S3WritableFile support multi-thread upload to S3.

Note: Not support S3 when encryption enabled.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2023-02-28T06:10:42Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Lloyd-Pottiger
flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

JinheLin · 2023-02-28T06:10:48Z

/build

dbms/src/Storages/S3/S3Filename.h

dbms/src/Storages/S3/S3Filename.cpp

dbms/src/Encryption/FileProvider.cpp

dbms/src/Common/TiFlashMetrics.h

ti-chi-bot · 2023-03-01T07:17:24Z

@JinheLin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

flowbehappy

LGTM

JinheLin · 2023-03-01T12:16:34Z

/run-all-tests

dbms/src/Server/Server.cpp

dbms/src/Storages/S3/MockS3Client.cpp

dbms/src/Encryption/FileProvider.cpp

…ugh `FileProvider`.

JinheLin · 2023-03-02T06:08:04Z

/build

JaySon-Huang

LGTM

JaySon-Huang · 2023-03-02T06:12:30Z

/merge

ti-chi-bot · 2023-03-02T06:12:31Z

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-03-02T06:12:32Z

This pull request has been accepted and is ready to merge.

Commit hash: 6029329

JinheLin · 2023-03-02T07:02:34Z

/merge

ti-chi-bot · 2023-03-02T07:02:36Z

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-03-02T07:02:37Z

This pull request has been accepted and is ready to merge.

Commit hash: 20b7de5

ti-chi-bot · 2023-03-02T08:02:52Z

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

flowbehappy · 2023-03-02T08:31:04Z

/merge

ti-chi-bot · 2023-03-02T08:31:05Z

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 28, 2023

ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 28, 2023

JaySon-Huang reviewed Feb 28, 2023

View reviewed changes

dbms/src/Storages/S3/S3Filename.h Outdated Show resolved Hide resolved

JaySon-Huang reviewed Feb 28, 2023

View reviewed changes

dbms/src/Storages/S3/S3Filename.cpp Outdated Show resolved Hide resolved

JaySon-Huang reviewed Feb 28, 2023

View reviewed changes

dbms/src/Encryption/FileProvider.cpp Show resolved Hide resolved

flowbehappy reviewed Mar 1, 2023

View reviewed changes

dbms/src/Common/TiFlashMetrics.h Show resolved Hide resolved

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2023

Storage: DMFile supports read/write from S3.

1dde2d6

flowbehappy approved these changes Mar 1, 2023

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2023

Fix conflict

cadea93

JinheLin force-pushed the s3-basic-rw branch from e575c35 to cadea93 Compare March 1, 2023 11:59

JinheLin added 2 commits March 1, 2023 20:03

fix

daac3f5

fix

814a750

JinheLin requested a review from JaySon-Huang March 1, 2023 12:25

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2023

Lloyd-Pottiger reviewed Mar 2, 2023

View reviewed changes

dbms/src/Server/Server.cpp Show resolved Hide resolved

dbms/src/Storages/S3/MockS3Client.cpp Show resolved Hide resolved

Lloyd-Pottiger approved these changes Mar 2, 2023

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2023

JaySon-Huang reviewed Mar 2, 2023

View reviewed changes

dbms/src/Encryption/FileProvider.cpp Outdated Show resolved Hide resolved

JaySon-Huang reviewed Mar 2, 2023

View reviewed changes

dbms/src/Encryption/FileProvider.cpp Outdated Show resolved Hide resolved

JinheLin added 2 commits March 2, 2023 13:13

Add s3 prefix required in file path if want to read/write object thro…

ea5e2a2

…ugh `FileProvider`.

Fix header.

577d8ed

JaySon-Huang approved these changes Mar 2, 2023

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2023

Format

20b7de5

JinheLin force-pushed the s3-basic-rw branch from 6029329 to 20b7de5 Compare March 2, 2023 07:02

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2023

ti-chi-bot added 2 commits March 2, 2023 15:02

Merge branch 'master' into s3-basic-rw

557d077

Merge branch 'master' into s3-basic-rw

85fe03f

ti-chi-bot merged commit 0b863a4 into pingcap:master Mar 2, 2023

JinheLin deleted the s3-basic-rw branch June 4, 2024 08:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage: DMFile supports read/write from S3. #6913

Storage: DMFile supports read/write from S3. #6913

JinheLin commented Feb 28, 2023 •

edited

Loading

ti-chi-bot commented Feb 28, 2023 •

edited

Loading

JinheLin commented Feb 28, 2023

ti-chi-bot commented Mar 1, 2023

flowbehappy left a comment

JinheLin commented Mar 1, 2023

JinheLin commented Mar 2, 2023

JaySon-Huang left a comment

JaySon-Huang commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

JinheLin commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

flowbehappy commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

Storage: DMFile supports read/write from S3. #6913

Storage: DMFile supports read/write from S3. #6913

Conversation

JinheLin commented Feb 28, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Feb 28, 2023 • edited Loading

JinheLin commented Feb 28, 2023

ti-chi-bot commented Mar 1, 2023

flowbehappy left a comment

Choose a reason for hiding this comment

JinheLin commented Mar 1, 2023

JinheLin commented Mar 2, 2023

JaySon-Huang left a comment

Choose a reason for hiding this comment

JaySon-Huang commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

JinheLin commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

flowbehappy commented Mar 2, 2023

ti-chi-bot commented Mar 2, 2023

JinheLin commented Feb 28, 2023 •

edited

Loading

ti-chi-bot commented Feb 28, 2023 •

edited

Loading