Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 Lock service #6874

Merged
merged 23 commits into from
Feb 28, 2023
Merged

S3 Lock service #6874

merged 23 commits into from
Feb 28, 2023

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Feb 22, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6827

Problem Summary: We need one and only one tiflash node run S3 lock service.

What is changed and how it works?

Depends on

S3Filename

Generate the S3 object keys for local file or parsing the key from S3 object key

S3LockService

S3LockService provides two RPC interface and ensure these two operations with the same key (the S3 key of CheckpointDataFile/DTFile) is atomic on S3

  • TryAddLock
  • TryMarkDelete

If the owner changed, this service will return NotOwner with the new owner id to client. Client should retry the request to new owner.

S3LockClient

Make rpc request to the S3 GC owner. S3LockClient will automatically retry when owner is changed

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 22, 2023
@JaySon-Huang JaySon-Huang mentioned this pull request Feb 22, 2023
Closed
12 tasks
Lloyd-Pottiger
Lloyd-Pottiger reviewed Feb 22, 2023
View reviewed changes
dbms/src/Flash/Disaggregated/S3LockService.h Outdated Show resolved Hide resolved
dbms/src/Storages/S3/S3Filename.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/S3/S3Filename.cpp Outdated Show resolved Hide resolved
@JaySon-Huang
Copy link
Contributor Author

/rebuild

@JaySon-Huang JaySon-Huang mentioned this pull request Feb 22, 2023
Merged
12 tasks
@JaySon-Huang JaySon-Huang force-pushed the lock_service branch 2 times, most recently from 0899b02 to 3165fc6 Compare February 23, 2023 11:23
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang JaySon-Huang mentioned this pull request Feb 25, 2023
Merged
17 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 27, 2023
JaySon-Huang and others added 15 commits February 28, 2023 01:30
@JaySon-Huang
Prevent the bkg task shared by multiple threads
f816134 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@Lloyd-Pottiger @JaySon-Huang
Add S3LockService
80be5dc 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@JaySon-Huang
Cleanup codes
2a98b3f 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Parsing s3 key from S3FilenameView
db4aca6 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Check whether the node is owner
ff894d5 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Handle owner change inside S3LockClient
55553e9 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Check the ownership after lock/delmark
5fd075d 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Add logging && metrics
b7c7c9b 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Add mock s3 lock client
78ebe10 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
clean
6bb517d 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
fix frequently keep alive
fb821c9 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Revert "fix frequently keep alive"
3f5b062 
This reverts commit fb821c9.
@JaySon-Huang
Fix for compute node
5c40ffb 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Use a shared S3 client
125d0fe 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Revert "Prevent the bkg task shared by multiple threads"
0ac01ab 
This reverts commit f816134.
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 994c65b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@SeaRise
Copy link
Contributor

SeaRise commented Feb 28, 2023

/run-unit-test

1 similar comment
@JaySon-Huang
Copy link
Contributor Author

/run-unit-test

@JaySon-Huang
Copy link
Contributor Author

/rebuild

@ti-chi-bot
Copy link
Member

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ee10e4d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@JaySon-Huang
Speedup testing
8568962 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8568962

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@JaySon-Huang
fix
32b5aa4 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@JaySon-Huang
Copy link
Contributor Author

/run-unit-test

@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 32b5aa4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@ti-chi-bot ti-chi-bot merged commit dc28555 into pingcap:master Feb 28, 2023
@JaySon-Huang JaySon-Huang deleted the lock_service branch August 19, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JaySon-Huang @ti-chi-bot @flowbehappy @SeaRise @Lloyd-Pottiger