Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline: Support pipeline table scan in UT #6831

Merged
merged 19 commits into from
Mar 7, 2023
Merged

Pipeline: Support pipeline table scan in UT #6831

merged 19 commits into from
Mar 7, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Feb 16, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6518

Problem Summary:
Currently only support table scan in unit test.
Will run table scan in ft when exchange is supported in pipeline

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JinheLin
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Feb 16, 2023
SeaRise
SeaRise reviewed Feb 16, 2023
View reviewed changes
dbms/src/Operators/UnorderedSourceOp.h Outdated Show resolved Hide resolved
dbms/src/Operators/UnorderedSourceOp.h Outdated Show resolved Hide resolved
dbms/src/Operators/UnorderedSourceOp.h Outdated Show resolved Hide resolved
dbms/src/Operators/UnorderedSourceOp.cpp Outdated Show resolved Hide resolved
dbms/src/Operators/UnorderedSourceOp.cpp Outdated Show resolved Hide resolved
@SeaRise SeaRise self-requested a review February 20, 2023 08:54
SeaRise
SeaRise reviewed Feb 20, 2023
View reviewed changes
dbms/src/Operators/UnorderedSourceOp.h Outdated Show resolved Hide resolved
dbms/src/Operators/UnorderedSourceOp.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/ReadThread/WorkQueue.h Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/ReadThread/WorkQueue.h Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp Show resolved Hide resolved
@SeaRise SeaRise mentioned this pull request Feb 21, 2023
Closed
25 tasks
SeaRise
SeaRise approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

dbms/src/Operators/UnorderedSourceOp.cpp Outdated Show resolved Hide resolved
dbms/src/Operators/UnorderedSourceOp.cpp Outdated Show resolved Hide resolved
dbms/src/Operators/UnorderedSourceOp.h Show resolved Hide resolved
dbms/src/Operators/UnorderedSourceOp.h Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2023
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2023
SeaRise
SeaRise reviewed Mar 7, 2023
View reviewed changes
dbms/src/Debug/MockStorage.cpp Outdated Show resolved Hide resolved
dbms/src/Operators/UnorderedSourceOp.h

namespace DB
{
class UnorderedSourceOp : public SourceOp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding some comments here?

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Mar 7, 2023

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5989b12

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Mar 7, 2023

/run-integration-tests

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Mar 7, 2023

/rebuild

@ywqzzy ywqzzy force-pushed the support_pipeline_table_scan branch from 5989b12 to faa3e3a Compare March 7, 2023 06:53
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Mar 7, 2023

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: be01311

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2023
@ti-chi-bot
Copy link
Member

@ywqzzy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 13a6f23 into pingcap:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@JinheLin JinheLin JinheLin approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywqzzy @ti-chi-bot @JinheLin @SeaRise