-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PageStorage: background version compact for v2 (#6446) #6465
PageStorage: background version compact for v2 (#6446) #6465
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
done by #6447 |
This is an automated cherry-pick of #6446
What problem does this PR solve?
Issue Number: close #6407
Problem Summary:
In the previous version, PageStorage v2 do the in-memory version list compaction when snapshot is released. Because multiple snapshot could be released concurrently, this causes some redundant CPU/memory resources.
What's more, slow-releasing snapshots cause DeltaTree's delta-compact task running slowly. This leads to many ColumnFileTiny remain not compacted and causing OOM.
What is changed and how it works?
Move the in-memory version list compaction to a background pool that is inited when PS v2 instances are created.
Check List
Tests
Side effects
Documentation
Release note