Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make join as top level operator #6356

Merged
merged 11 commits into from
Dec 5, 2022
Merged

make join as top level operator #6356

merged 11 commits into from
Dec 5, 2022

Conversation

mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Nov 24, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6351

Problem Summary:

What is changed and how it works?

make join as top level operator

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

make join as top level operator.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2022
@mengxin9014
Copy link
Contributor Author

/run-all-tests

@mengxin9014
Copy link
Contributor Author

/run-all-tests

@mengxin9014
Copy link
Contributor Author

/run-all-tests

SeaRise
SeaRise reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that both

tiflash/dbms/src/Flash/Planner/plans/PhysicalJoin.h

Line 79 in e77d01c

NamesAndTypesList columns_added_by_join;
and

tiflash/dbms/src/Flash/Coprocessor/JoinInterpreterHelper.cpp

Line 304 in 25e5c1c

NamesAndTypesList TiFlashJoin::genColumnsAddedByJoin(
are useless.
Others LGTM.

@mengxin9014
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2022
@mengxin9014
Copy link
Contributor Author

It seems that both

tiflash/dbms/src/Flash/Planner/plans/PhysicalJoin.h

Line 79 in e77d01c

NamesAndTypesList columns_added_by_join;

and

tiflash/dbms/src/Flash/Coprocessor/JoinInterpreterHelper.cpp

Line 304 in 25e5c1c

NamesAndTypesList TiFlashJoin::genColumnsAddedByJoin(

are useless.
Others LGTM.

remove.

@mengxin9014
Copy link
Contributor Author

/run-all-tests

SeaRise
SeaRise approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
windtalker
windtalker approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 5, 2022
@mengxin9014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8b26c1b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2022
@ti-chi-bot
Copy link
Member

@mengxin9014: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mengxin9014
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit e255112 into pingcap:master Dec 5, 2022
@mengxin9014 mengxin9014 deleted the mx/makeJoinAsTopLevelOperator branch December 5, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Join as top level operator
4 participants
@mengxin9014 @ti-chi-bot @windtalker @SeaRise