Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement push down instr function to tiflash #6081

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
b2f0af8
Merge pull request #1 from pingcap/master
lizhenhuan Jun 25, 2022
28ae999
Implement ReverseUTF8/Reverse function push down #5111
lizhenhuan Jun 25, 2022
f02759a
format
Lloyd-Pottiger Jun 27, 2022
f1e7768
Merge pull request #2 from pingcap/master
lizhenhuan Jun 30, 2022
1e5be6d
implement reverse push down to tiflash
lizhenhuan Jun 30, 2022
306aa06
pushdown reverse to TiFlash
lizhenhuan Jul 1, 2022
cfa9cad
pushdown reverse to TiFlash
lizhenhuan Jul 1, 2022
1ca32f3
push down reverse to tiflash
lizhenhuan Jul 1, 2022
ba825b1
reverse test case is ok
lizhenhuan Jul 4, 2022
9f2defe
fix reverse test problem
lizhenhuan Jul 5, 2022
062ba64
fix reverse test case problem
lizhenhuan Jul 5, 2022
1a48b5f
fix reverse test case problem
lizhenhuan Jul 6, 2022
d561f59
Merge branch 'master' into master
mengxin9014 Jul 6, 2022
fad4933
Merge branch 'master' into master
ti-chi-bot Jul 7, 2022
6741072
Merge branch 'master' into master
ti-chi-bot Jul 7, 2022
4ebb91b
merge form master
lizhenhuan Jul 31, 2022
d72e330
Merge branch 'pingcap:master' into master
lizhenhuan Oct 3, 2022
ad3da65
implement instr push down to tiflash
lizhenhuan Oct 6, 2022
a0be732
add instr
lizhenhuan Oct 6, 2022
324355a
fix
lizhenhuan Oct 6, 2022
4ea338e
fix format error
lizhenhuan Oct 8, 2022
a136b00
fix
lizhenhuan Oct 8, 2022
90d1bd0
fix
lizhenhuan Oct 9, 2022
802c5c0
fix utf8
lizhenhuan Oct 9, 2022
5c2da8f
fix
lizhenhuan Oct 9, 2022
a3620fc
add utf8 test case
lizhenhuan Oct 10, 2022
ea4e6ab
fix code
lizhenhuan Oct 10, 2022
faa3bbf
fix code
lizhenhuan Oct 23, 2022
aaa6079
fix code
lizhenhuan Oct 24, 2022
7a0cc91
fix code
lizhenhuan Oct 24, 2022
360fb7c
fix code
lizhenhuan Oct 29, 2022
7ee7e26
fix code
lizhenhuan Oct 29, 2022
779d481
Merge branch 'master' into instr_push_down
lizhenhuan Oct 31, 2022
c412cb3
remove const const
lizhenhuan Oct 31, 2022
f561a54
Merge branch 'instr_push_down' of github.com:lizhenhuan/tiflash into …
lizhenhuan Oct 31, 2022
1711659
fix code
lizhenhuan Oct 31, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix reverse test case problem
  • Loading branch information
lizhenhuan committed Jul 5, 2022
commit 062ba64eb6b09c5accd95e64cb9ae3ecac8389a7
27 changes: 21 additions & 6 deletions dbms/src/Functions/tests/gtest_strings_reverse.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@

#pragma GCC diagnostic pop

namespace DB
{
namespace tests
namespace DB::tests
{
class StringReverse : public DB::tests::FunctionTest
{
Expand All @@ -39,6 +37,11 @@ class StringReverse : public DB::tests::FunctionTest
{
return createColumn<Nullable<String>>(v);
}

static ColumnWithTypeAndName toConst(const String & s)
{
return createConstColumn<String>(1, s);
}
};
// test reverse
TEST_F(StringReverse, stringReverseTest)
Expand Down Expand Up @@ -70,20 +73,32 @@ try
CATCH


// test NULL
// test null and const
TEST_F(StringReverse, nullTest)
{
ASSERT_COLUMN_EQ(
toNullableVec({"", " ", {}, "pacgnip"}),
executeFunction(
"reverse",
toNullableVec({"", " ", {}, "pingcap"})));

ASSERT_COLUMN_EQ(
toNullableVec({"", " ", {}, "pacgnip"}),
executeFunction(
"reverseUTF8",
toNullableVec({"", " ", {}, "pingcap"})));

ASSERT_COLUMN_EQ(
toConst("pacgnip"),
executeFunction(
"reverse",
toConst("pingcap")));

ASSERT_COLUMN_EQ(
toConst("pacgnip"),
executeFunction(
"reverseUTF8",
toConst("pingcap")));
}

} // namespace tests
} // namespace DB
} // namespace DB::tests