Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong alloc size when do heavy gc for blob file #5693

Merged
merged 3 commits into from
Aug 25, 2022
Merged

fix wrong alloc size when do heavy gc for blob file #5693

merged 3 commits into from
Aug 25, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Aug 24, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5558

Problem Summary: The alloc size for BlobFile when do heavy gc may be wrong which is introduced by #5544

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 24, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 25, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 25, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                      617               141    77.15%          53                 0   100.00%        1190               233    80.42%         322                92    71.43%
tests/gtest_blob_store.cpp         520                85    83.65%          29                 0   100.00%        1307                12    99.08%         180                52    71.11%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             1137               226    80.12%          82                 0   100.00%        2497               245    90.19%         502               144    71.31%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18419      8329             54.78%    212991  85980        59.63%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2022
JaySon-Huang
JaySon-Huang approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 25, 2022

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5adc973

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 25, 2022

/rebuild

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 25, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                      617               141    77.15%          53                 0   100.00%        1190               233    80.42%         322                92    71.43%
tests/gtest_blob_store.cpp         520                85    83.65%          29                 0   100.00%        1307                12    99.08%         180                52    71.11%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             1137               226    80.12%          82                 0   100.00%        2497               245    90.19%         502               144    71.31%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18420      8328             54.79%    213002  86000        59.62%

full coverage report (for internal network access only)

@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 25, 2022

/run-integration-test

3 similar comments
@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 25, 2022

/run-integration-test

@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 25, 2022

/run-integration-test

@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 25, 2022

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 5510b1a into pingcap:master Aug 25, 2022
@lidezhu lidezhu deleted the fix-blobstore-metric branch August 25, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@hehechen hehechen Awaiting requested review from hehechen

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lidezhu @ti-chi-bot @sre-bot @JaySon-Huang @Lloyd-Pottiger