feat: implement hexInt/hexStr function push down #5280

YangKeao · 2022-07-03T13:34:23Z

What problem does this PR solve?

Issue Number: close #5107

Related PR: pingcap/tidb#35902

What is changed and how it works?

hexStr is manually implemented through convert every bytes to two characters.

hexInt is implemented by calling sprintf(_, "%X", _) directly.

Check List

Tests

Unit test
Integration test

Release note

Support to pushdown hexInt and hexStr to TiFlash

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

ti-chi-bot · 2022-07-03T13:34:24Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

SeaRise
gengliqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

SeaRise

Thanks for your contribution, nice job.

tests/fullstack-test/expr/hex_str.test

dbms/src/Functions/tests/gtest_strings_hexstr.cpp

dbms/src/Functions/tests/gtest_strings_hexint.cpp

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

SeaRise

Others LGTM

dbms/src/Functions/FunctionsString.cpp

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

gengliqi · 2022-07-06T10:56:48Z

/merge

ti-chi-bot · 2022-07-06T10:56:49Z

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-07-06T11:15:02Z

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                   347               155    55.33%          45                15    66.67%         638               294    53.92%         412               197    52.18%
Functions/FunctionsString.cpp                   1275               384    69.88%         247                74    70.04%        2838               772    72.80%         778               292    62.47%
Functions/tests/gtest_strings_hexint.cpp         172                43    75.00%           1                 0   100.00%          45                 0   100.00%          52                27    48.08%
Functions/tests/gtest_strings_hexstr.cpp          77                28    63.64%           1                 0   100.00%          20                 0   100.00%          22                12    45.45%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1871               610    67.40%         294                89    69.73%        3541              1066    69.90%        1264               528    58.23%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18430      9645             47.67%    207408  96543        53.45%

full coverage report (for internal network access only)

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

…hex-int-str-arg

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Lloyd-Pottiger · 2022-07-20T08:33:29Z

/run-all-tests

sre-bot · 2022-07-20T08:52:09Z

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                   347               141    59.37%          45                11    75.56%         638               271    57.52%         412               190    53.88%
Functions/FunctionsString.cpp                   1353               361    73.32%         259                68    73.75%        2987               732    75.49%         828               287    65.34%
Functions/tests/gtest_strings_hexint.cpp         172                43    75.00%           1                 0   100.00%          45                 0   100.00%          52                27    48.08%
Functions/tests/gtest_strings_hexstr.cpp          77                28    63.64%           1                 0   100.00%          20                 0   100.00%          22                12    45.45%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1949               573    70.60%         306                79    74.18%        3690              1003    72.82%        1314               516    60.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18644      9394             49.61%    212552  94887        55.36%

full coverage report (for internal network access only)

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

…hex-int-str-arg

tests/fullstack-test/expr/hex_str.test

Willendless · 2022-07-20T20:53:40Z

/run-all-tests

Willendless · 2022-07-20T21:08:04Z

/run-all-tests

sre-bot · 2022-07-20T21:19:20Z

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                   347               141    59.37%          45                11    75.56%         638               271    57.52%         412               190    53.88%
Functions/FunctionsString.cpp                   1353               361    73.32%         259                68    73.75%        2987               732    75.49%         828               287    65.34%
Functions/tests/gtest_strings_hexint.cpp         172                43    75.00%           1                 0   100.00%          45                 0   100.00%          52                27    48.08%
Functions/tests/gtest_strings_hexstr.cpp          77                28    63.64%           1                 0   100.00%          20                 0   100.00%          22                12    45.45%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1949               573    70.60%         306                79    74.18%        3690              1003    72.82%        1314               516    60.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18650      9396             49.62%    212684  94936        55.36%

full coverage report (for internal network access only)

Lloyd-Pottiger · 2022-07-21T02:14:51Z

/run-integration-test

Willendless · 2022-07-21T16:24:58Z

/run-all-tests

sre-bot · 2022-07-21T16:45:17Z

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                   347               141    59.37%          45                11    75.56%         638               271    57.52%         412               190    53.88%
Functions/FunctionsString.cpp                   1353               361    73.32%         259                68    73.75%        2987               732    75.49%         828               287    65.34%
Functions/tests/gtest_strings_hexint.cpp         172                43    75.00%           1                 0   100.00%          45                 0   100.00%          52                27    48.08%
Functions/tests/gtest_strings_hexstr.cpp          77                28    63.64%           1                 0   100.00%          20                 0   100.00%          22                12    45.45%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1949               573    70.60%         306                79    74.18%        3690              1003    72.82%        1314               516    60.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18650      9398             49.61%    212686  94988        55.34%

full coverage report (for internal network access only)

SeaRise · 2022-07-21T20:56:49Z

/run-all-tests

sre-bot · 2022-07-21T21:14:22Z

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                   347               141    59.37%          45                11    75.56%         638               271    57.52%         412               190    53.88%
Functions/FunctionsString.cpp                   1353               361    73.32%         259                68    73.75%        2987               732    75.49%         828               287    65.34%
Functions/tests/gtest_strings_hexint.cpp         172                43    75.00%           1                 0   100.00%          45                 0   100.00%          52                27    48.08%
Functions/tests/gtest_strings_hexstr.cpp          77                28    63.64%           1                 0   100.00%          20                 0   100.00%          22                12    45.45%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1949               573    70.60%         306                79    74.18%        3690              1003    72.82%        1314               516    60.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18799      9449             49.74%    214173  95471        55.42%

full coverage report (for internal network access only)

SeaRise · 2022-07-22T02:54:20Z

/merge

ti-chi-bot · 2022-07-22T02:54:21Z

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-22T02:54:23Z

This pull request has been accepted and is ready to merge.

Commit hash: 844eda6

sre-bot · 2022-07-22T03:06:14Z

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                   347               141    59.37%          45                11    75.56%         638               271    57.52%         412               190    53.88%
Functions/FunctionsString.cpp                   1353               361    73.32%         259                68    73.75%        2987               732    75.49%         828               287    65.34%
Functions/tests/gtest_strings_hexint.cpp         172                43    75.00%           1                 0   100.00%          45                 0   100.00%          52                27    48.08%
Functions/tests/gtest_strings_hexstr.cpp          77                28    63.64%           1                 0   100.00%          20                 0   100.00%          22                12    45.45%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1949               573    70.60%         306                79    74.18%        3690              1003    72.82%        1314               516    60.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18799      9451             49.73%    214173  95547        55.39%

full coverage report (for internal network access only)

breezewish · 2022-07-25T02:45:54Z

Seems that there will be issues when using LLVM as the compiler:

/Library/Developer/CommandLineTools/usr/bin/c++ -DBOOST_CONTEXT_EXPORT="" -DBOOST_CONTEXT_NO_LIB -DBOOST_CONTEXT_STATIC_LINK -DBOOST_FIBER_NO_LIB -DBOOST_FIBER_STATIC_LINK -DBOOST_SYSTEM_NO_DEPRECATED -DCARES_STATICLIB -DFIU_ENABLE -DLZ4_DISABLE_DEPRECATE_WARNINGS=1 -DPOCO_STATIC -DPOCO_UNBUNDLED_ZLIB -DTIFLASH_COMPILER_VPCLMULQDQ_SUPPORT=0 -DTIFLASH_ENABLE_ASIMD_SUPPORT=1 -DTIFLASH_SOURCE_PREFIX=\"/Users/breezewish/Work/tiflash\" -I/Users/breezewish/Work/tiflash/contrib/libdivide -I/Users/breezewish/Work/tiflash/contrib/libmetrohash/src -I/Users/breezewish/Work/tiflash/contrib/libfarmhash -I/Users/breezewish/Work/tiflash/dbms/src -I/Users/breezewish/Work/tiflash/contrib/tiflash-proxy/raftstore-proxy/ffi/src -I/Users/breezewish/Work/tiflash/cmake-build-debug/dbms/src -I/Users/breezewish/Work/tiflash/contrib/double-conversion -I/Users/breezewish/Work/tiflash/contrib/boost -I/Users/breezewish/Work/tiflash/contrib/xxHash -I/Users/breezewish/Work/tiflash/contrib/libpcg-random/include -I/Users/breezewish/Work/tiflash/contrib/libcityhash/include -I/Users/breezewish/Work/tiflash/libs/libcommon/include -I/Users/breezewish/Work/tiflash/cmake-build-debug/libs/libcommon/include -I/Users/breezewish/Work/tiflash/libs/libpocoext/include -I/Users/breezewish/Work/tiflash/contrib/poco/Data/include -I/Users/breezewish/Work/tiflash/contrib/poco/Foundation/include -I/Users/breezewish/Work/tiflash/contrib/zlib-ng -I/Users/breezewish/Work/tiflash/cmake-build-debug/contrib/zlib-ng -I/Users/breezewish/Work/tiflash/contrib/poco/Util/include -I/Users/breezewish/Work/tiflash/contrib/poco/XML/include -I/Users/breezewish/Work/tiflash/contrib/poco/JSON/include -I/Users/breezewish/Work/tiflash/contrib/poco/Net/include -I/Users/breezewish/Work/tiflash/contrib/cctz/include -I/Users/breezewish/Work/tiflash/contrib/lz4/lib -I/Users/breezewish/Work/tiflash/contrib/zstd/lib -I/Users/breezewish/Work/tiflash/contrib/client-c/third_party/libfiu/libfiu -I/Users/breezewish/Work/tiflash/contrib/prometheus-cpp/core/include -I/Users/breezewish/Work/tiflash/cmake-build-debug/contrib/prometheus-cpp-cmake/core/include -I/Users/breezewish/Work/tiflash/contrib/prometheus-cpp/push/include -I/Users/breezewish/Work/tiflash/cmake-build-debug/contrib/prometheus-cpp-cmake/push/include -I/Users/breezewish/Work/tiflash/contrib/prometheus-cpp/pull/include -I/Users/breezewish/Work/tiflash/cmake-build-debug/contrib/prometheus-cpp-cmake/pull/include -I/Users/breezewish/Work/tiflash/contrib/cpptoml -I/Users/breezewish/Work/tiflash/contrib/poco/NetSSL_OpenSSL/include -I/Users/breezewish/Work/tiflash/contrib/poco/Crypto/include -I/Users/breezewish/Work/tiflash/contrib/xxHash/cmake_unofficial/.. -I/Users/breezewish/Work/tiflash/contrib/kvproto/cpp -I/Users/breezewish/Work/tiflash/contrib/kvproto/cpp/kvproto -I/Users/breezewish/Work/tiflash/contrib/grpc/include -I/Users/breezewish/Work/tiflash/contrib/client-c/include -I/Users/breezewish/Work/tiflash/cmake-build-debug/contrib/grpc/third_party/cares/cares -I/Users/breezewish/Work/tiflash/contrib/grpc/third_party/cares/cares -I/Users/breezewish/Work/tiflash/contrib/tipb/cpp -I/Users/breezewish/Work/tiflash/cmake-build-debug/dbms/src/Storages/DeltaMerge/File/dtpb -I/Users/breezewish/Work/tiflash/contrib/libbtrie/include -I/Users/breezewish/Work/tiflash/contrib/abseil-cpp -I/Users/breezewish/Work/tiflash/libs/libconsistent-hashing -I/Users/breezewish/Work/tiflash/cmake-build-debug/contrib/libfarmhash -isystem /Users/breezewish/Work/tiflash/contrib/fmtlib-cmake/../fmtlib/include -isystem /Users/breezewish/Work/tiflash/libs/libsymbolization/include -isystem /Users/breezewish/Work/tiflash/contrib/boringssl/include -isystem /Users/breezewish/Work/tiflash/contrib/protobuf/src -isystem /Users/breezewish/Work/tiflash/contrib/re2 -isystem /Users/breezewish/Work/tiflash/cmake-build-debug/contrib/re2-cmake -D__GLIBCXX_BITSIZE_INT_N_0=128 -D__GLIBCXX_TYPE_INT_N_0=__int128   -pipe  -fno-omit-frame-pointer  -Wall -Wno-unused-command-line-argument  -Wnon-virtual-dtor  -Wextra -Werror -g -g3 -ggdb3 -O0 -fverbose-asm -fno-inline  -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk -fPIC -DDUMMY_BACKTRACE -std=gnu++17 -MD -MT dbms/src/Functions/CMakeFiles/clickhouse_functions.dir/FunctionsString.cpp.o -MF dbms/src/Functions/CMakeFiles/clickhouse_functions.dir/FunctionsString.cpp.o.d -o dbms/src/Functions/CMakeFiles/clickhouse_functions.dir/FunctionsString.cpp.o -c /Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5288:100: error: format specifies type 'unsigned long' but the argument has type 'DB::UInt64' (aka 'unsigned long long') [-Werror,-Wformat]
            int print_size = sprintf(reinterpret_cast<char *>(&res_chars[prev_res_offset]), "%lX", number);
                                                                                             ~~~   ^~~~~~
                                                                                             %llX
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5243:13: note: in instantiation of function template specialization 'DB::FunctionHexInt::executeHexInt<unsigned char>' requested here
        if (executeHexInt<UInt8>(block, arguments, result)
            ^
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5288:100: error: format specifies type 'unsigned long' but the argument has type 'DB::UInt64' (aka 'unsigned long long') [-Werror,-Wformat]
            int print_size = sprintf(reinterpret_cast<char *>(&res_chars[prev_res_offset]), "%lX", number);
                                                                                             ~~~   ^~~~~~
                                                                                             %llX
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5244:16: note: in instantiation of function template specialization 'DB::FunctionHexInt::executeHexInt<unsigned short>' requested here
            || executeHexInt<UInt16>(block, arguments, result)
               ^
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5288:100: error: format specifies type 'unsigned long' but the argument has type 'DB::UInt64' (aka 'unsigned long long') [-Werror,-Wformat]
            int print_size = sprintf(reinterpret_cast<char *>(&res_chars[prev_res_offset]), "%lX", number);
                                                                                             ~~~   ^~~~~~
                                                                                             %llX
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5245:16: note: in instantiation of function template specialization 'DB::FunctionHexInt::executeHexInt<unsigned int>' requested here
            || executeHexInt<UInt32>(block, arguments, result)
               ^
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5288:100: error: format specifies type 'unsigned long' but the argument has type 'DB::UInt64' (aka 'unsigned long long') [-Werror,-Wformat]
            int print_size = sprintf(reinterpret_cast<char *>(&res_chars[prev_res_offset]), "%lX", number);
                                                                                             ~~~   ^~~~~~
                                                                                             %llX
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5246:16: note: in instantiation of function template specialization 'DB::FunctionHexInt::executeHexInt<unsigned long long>' requested here
            || executeHexInt<UInt64>(block, arguments, result)
               ^
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5288:100: error: format specifies type 'unsigned long' but the argument has type 'DB::UInt64' (aka 'unsigned long long') [-Werror,-Wformat]
            int print_size = sprintf(reinterpret_cast<char *>(&res_chars[prev_res_offset]), "%lX", number);
                                                                                             ~~~   ^~~~~~
                                                                                             %llX
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5247:16: note: in instantiation of function template specialization 'DB::FunctionHexInt::executeHexInt<signed char>' requested here
            || executeHexInt<Int8>(block, arguments, result)
               ^
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5288:100: error: format specifies type 'unsigned long' but the argument has type 'DB::UInt64' (aka 'unsigned long long') [-Werror,-Wformat]
            int print_size = sprintf(reinterpret_cast<char *>(&res_chars[prev_res_offset]), "%lX", number);
                                                                                             ~~~   ^~~~~~
                                                                                             %llX
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5248:16: note: in instantiation of function template specialization 'DB::FunctionHexInt::executeHexInt<short>' requested here
            || executeHexInt<Int16>(block, arguments, result)
               ^
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5288:100: error: format specifies type 'unsigned long' but the argument has type 'DB::UInt64' (aka 'unsigned long long') [-Werror,-Wformat]
            int print_size = sprintf(reinterpret_cast<char *>(&res_chars[prev_res_offset]), "%lX", number);
                                                                                             ~~~   ^~~~~~
                                                                                             %llX
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5249:16: note: in instantiation of function template specialization 'DB::FunctionHexInt::executeHexInt<int>' requested here
            || executeHexInt<Int32>(block, arguments, result)
               ^
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5288:100: error: format specifies type 'unsigned long' but the argument has type 'DB::UInt64' (aka 'unsigned long long') [-Werror,-Wformat]
            int print_size = sprintf(reinterpret_cast<char *>(&res_chars[prev_res_offset]), "%lX", number);
                                                                                             ~~~   ^~~~~~
                                                                                             %llX
/Users/breezewish/Work/tiflash/dbms/src/Functions/FunctionsString.cpp:5250:16: note: in instantiation of function template specialization 'DB::FunctionHexInt::executeHexInt<long long>' requested here
            || executeHexInt<Int64>(block, arguments, result))
               ^
8 errors generated.

YangKeao added 2 commits July 3, 2022 21:29

implement hex str function

796e9b4

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

implement hex int function

2f6d92b

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 3, 2022

format codes

dfff46b

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

YangKeao force-pushed the impl-hex-int-str-arg branch from 8826f4a to dfff46b Compare July 3, 2022 13:44

YangKeao mentioned this pull request Jul 3, 2022

feat: push down hexInt/hexStr function to tiflash pingcap/tidb#35902

Merged

12 tasks

fix test arguments order

4f11229

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

YangKeao force-pushed the impl-hex-int-str-arg branch from 757b7a6 to 4f11229 Compare July 3, 2022 14:21

Willendless mentioned this pull request Jul 3, 2022

Call For Participation: implement function push down #5092

Open

fix clang-lint

e057637

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

YangKeao force-pushed the impl-hex-int-str-arg branch from cce8412 to e057637 Compare July 4, 2022 11:39

SeaRise reviewed Jul 5, 2022

View reviewed changes

YangKeao added 2 commits July 5, 2022 21:10

Merge remote-tracking branch 'upstream/master' into impl-hex-int-str-arg

0ca9582

add more test

9915484

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

YangKeao force-pushed the impl-hex-int-str-arg branch from a3f71cc to 9915484 Compare July 5, 2022 14:42

SeaRise self-requested a review July 6, 2022 02:33

SeaRise approved these changes Jul 6, 2022

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Show resolved Hide resolved

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2022

fix typo in comment

5e8ff53

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

gengliqi approved these changes Jul 6, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2022

Merge branch 'master' into impl-hex-int-str-arg

5f5bc7c

Merge branch 'master' into impl-hex-int-str-arg

954310f

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2022

YangKeao added 4 commits July 20, 2022 14:44

replace single quote to double quote in test

a12f384

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Merge remote-tracking branch 'origin/impl-hex-int-str-arg' into impl-…

c2bf924

…hex-int-str-arg

Merge remote-tracking branch 'upstream/master' into impl-hex-int-str-arg

967eb57

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Merge branch 'master' into impl-hex-int-str-arg

5b56a45

YangKeao added 3 commits July 20, 2022 18:20

Merge remote-tracking branch 'upstream/master' into impl-hex-int-str-arg

d6f5feb

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>

Merge remote-tracking branch 'origin/impl-hex-int-str-arg' into impl-…

86cbf1c

…hex-int-str-arg

Merge remote-tracking branch 'upstream/master' into impl-hex-int-str-arg

d804daa

Lloyd-Pottiger reviewed Jul 20, 2022

View reviewed changes

tests/fullstack-test/expr/hex_str.test Outdated Show resolved Hide resolved

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2022

Merge branch 'master' into impl-hex-int-str-arg

f266176

Merge branch 'master' into impl-hex-int-str-arg

844eda6

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2022

ti-chi-bot merged commit 6a8c26c into pingcap:master Jul 22, 2022

YangKeao mentioned this pull request Jul 25, 2022

fix hexInt sprintf format pattern #5460

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement hexInt/hexStr function push down #5280

feat: implement hexInt/hexStr function push down #5280

YangKeao commented Jul 3, 2022 •

edited

Loading

ti-chi-bot commented Jul 3, 2022 •

edited

Loading

SeaRise left a comment

SeaRise left a comment

gengliqi commented Jul 6, 2022

ti-chi-bot commented Jul 6, 2022

sre-bot commented Jul 6, 2022

Lloyd-Pottiger commented Jul 20, 2022

sre-bot commented Jul 20, 2022

Willendless commented Jul 20, 2022

Willendless commented Jul 20, 2022

sre-bot commented Jul 20, 2022

Lloyd-Pottiger commented Jul 21, 2022

Willendless commented Jul 21, 2022

sre-bot commented Jul 21, 2022

SeaRise commented Jul 21, 2022

sre-bot commented Jul 21, 2022

SeaRise commented Jul 22, 2022

ti-chi-bot commented Jul 22, 2022

ti-chi-bot commented Jul 22, 2022

sre-bot commented Jul 22, 2022

breezewish commented Jul 25, 2022

feat: implement hexInt/hexStr function push down #5280

feat: implement hexInt/hexStr function push down #5280

Conversation

YangKeao commented Jul 3, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jul 3, 2022 • edited Loading

SeaRise left a comment

Choose a reason for hiding this comment

SeaRise left a comment

Choose a reason for hiding this comment

gengliqi commented Jul 6, 2022

ti-chi-bot commented Jul 6, 2022

sre-bot commented Jul 6, 2022

Coverage for changed files

Coverage summary

Lloyd-Pottiger commented Jul 20, 2022

sre-bot commented Jul 20, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 20, 2022

Willendless commented Jul 20, 2022

sre-bot commented Jul 20, 2022

Coverage for changed files

Coverage summary

Lloyd-Pottiger commented Jul 21, 2022

Willendless commented Jul 21, 2022

sre-bot commented Jul 21, 2022

Coverage for changed files

Coverage summary

SeaRise commented Jul 21, 2022

sre-bot commented Jul 21, 2022

Coverage for changed files

Coverage summary

SeaRise commented Jul 22, 2022

ti-chi-bot commented Jul 22, 2022

ti-chi-bot commented Jul 22, 2022

sre-bot commented Jul 22, 2022

Coverage for changed files

Coverage summary

breezewish commented Jul 25, 2022

YangKeao commented Jul 3, 2022 •

edited

Loading

ti-chi-bot commented Jul 3, 2022 •

edited

Loading