Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ReverseUTF8/Reverse function push down #5233
Implement ReverseUTF8/Reverse function push down #5233
Changes from 9 commits
b2f0af8
28ae999
f02759a
f1e7768
1e5be6d
306aa06
cfa9cad
1ca32f3
ba825b1
9f2defe
062ba64
1a48b5f
d561f59
fad4933
6741072
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing nullable means that the column can be null, you can refer here
tiflash/dbms/src/Functions/tests/gtest_strings_upper.cpp
Line 41 in 25545c4
tiflash/dbms/src/Functions/tests/gtest_strings_upper.cpp
Line 59 in 25545c4