Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add (Aggregation/ExchangeSender)InterpreterHelper to refine the code of executeAggregation and handleExchangeSender #4468

Closed
wants to merge 4 commits into from
Closed

add (Aggregation/ExchangeSender)InterpreterHelper to refine the code of executeAggregation and handleExchangeSender #4468

wants to merge 4 commits into from

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 28, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4118

Problem Summary:

What is changed and how it works?

move some codes from DAGQueryBlockInterpreter.cpp to (Aggregation/ExchangeSender)InterpreterHelper

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 28, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 28, 2022

Coverage for changed files

Filename                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
AggregationInterpreterHelper.h          38                38     0.00%           5                 5     0.00%          59                59     0.00%          36                36     0.00%
DAGQueryBlockInterpreter.cpp           354               354     0.00%          43                43     0.00%         839               839     0.00%         276               276     0.00%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  392               392     0.00%          48                48     0.00%         898               898     0.00%         312               312     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17052      9578             43.83%    191796  97031        49.41%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2022
@SeaRise SeaRise changed the title add AggregationInterpreterHelper to refine the code of executeAggregation add Aggregation/ExchangeSender)InterpreterHelper to refine the code of executeAggregation and handleExchangeSender Mar 28, 2022
@SeaRise SeaRise changed the title add Aggregation/ExchangeSender)InterpreterHelper to refine the code of executeAggregation and handleExchangeSender add (Aggregation/ExchangeSender)InterpreterHelper to refine the code of executeAggregation and handleExchangeSender Mar 28, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 28, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 28, 2022

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
AggregationInterpreterHelper.h             38                38     0.00%           5                 5     0.00%          59                59     0.00%          36                36     0.00%
DAGQueryBlockInterpreter.cpp              341               341     0.00%          43                43     0.00%         817               817     0.00%         264               264     0.00%
ExchangeSenderInterpreterHelper.h          14                14     0.00%           1                 1     0.00%          28                28     0.00%          12                12     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                     393               393     0.00%          49                49     0.00%         904               904     0.00%         312               312     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17053      9579             43.83%    191802  97029        49.41%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 28, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 28, 2022

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
AggregationInterpreterHelper.h             38                38     0.00%           5                 5     0.00%          59                59     0.00%          36                36     0.00%
DAGQueryBlockInterpreter.cpp              341               341     0.00%          43                43     0.00%         817               817     0.00%         264               264     0.00%
ExchangeSenderInterpreterHelper.h          14                14     0.00%           1                 1     0.00%          28                28     0.00%          12                12     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                     393               393     0.00%          49                49     0.00%         904               904     0.00%         312               312     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17053      9579             43.83%    191802  97024        49.41%

full coverage report (for internal network access only)

@SeaRise SeaRise closed this Mar 29, 2022
@SeaRise SeaRise deleted the add_AggInterpreterHelper branch March 29, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeaRise @ti-chi-bot @sre-bot