Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notice according to Apache license 2.0 4d #4182

Merged
merged 11 commits into from
Mar 7, 2022
Merged

Add notice according to Apache license 2.0 4d #4182

merged 11 commits into from
Mar 7, 2022

Conversation

zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Mar 4, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4188

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 7, 2022
hehechen and others added 10 commits March 7, 2022 12:36
@hehechen @zanmato1984
Support user to choose different compression algorithms and compressi…
f62ef11 
…on levels (#4161)

close pingcap/tiflash#3671

Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@bestwoody @zanmato1984
Metrics of threads (#4169)
f992979 
* add threads metrics

* add threads metrics

Signed-off-by: bestwoody <bestwoody@163.com>

* format

Signed-off-by: bestwoody <bestwoody@163.com>

* update threadpool into thread_pool

Signed-off-by: bestwoody <bestwoody@163.com>

* UPDATE_CUR_AND_MAX_METRIC

Signed-off-by: bestwoody <bestwoody@163.com>

* refine include

Signed-off-by: bestwoody <bestwoody@163.com>
Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@ywqzzy @zanmato1984
expression: support least/greatest for int/real. (#3801)
0985866 
close pingcap/tiflash#3358

Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@guo-shaoge @zanmato1984
add more case in bench_function_cast.cpp (#4109)
ee4ab31 
close pingcap/tiflash#4178

Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@zanmato1984
Add notice according to Apache license 2.0 4d
fbba413 
Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@zanmato1984
Update
dad3b87 
Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@zanmato1984
Add notice according to Apache license 2.0 4d
fe88fa5 
Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@zanmato1984
Update
81a2a95 
Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@jiaqizho @zanmato1984
Add a protect if snapshot can't get any valid version (#4171)
42b00a1 
close pingcap/tiflash#4179

Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@JaySon-Huang @zanmato1984
PageStorage: Fix BlobStore read with FieldReadInfos (#4181)
663e263 
ref pingcap/tiflash#3594

Signed-off-by: zanmato1984 <zanmato1984@gmail.com>
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 7, 2022
@zanmato1984
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@zanmato1984: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3969614

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 7, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16705      9452             43.42%    187277  95549        48.98%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 444d875 into pingcap:master Mar 7, 2022
@zanmato1984 zanmato1984 deleted the notice branch March 7, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@lidezhu lidezhu lidezhu approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add notice according to Apache License V2.0
10 participants
@zanmato1984 @ti-chi-bot @sre-bot @JaySon-Huang @lidezhu @hehechen @bestwoody @ywqzzy @guo-shaoge @jiaqizho