Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] test ckormanyos/wide-integer #4176

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

[DNM] test ckormanyos/wide-integer #4176

wants to merge 17 commits into from

Conversation

fuzhe1989
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

fuzhe1989 and others added 17 commits June 3, 2021 23:21
stage
8860686
WIP: compile wide_integer fail
e2d14f3 
```
/home/fuzhe/projects/tics/libs/libcommon/include/common/wide_integer_impl.h: In instantiation of ‘static constexpr wide::integer<Bits, Signed> wide::integer<Bits, Signed>::_impl::multiply(const wide::integer<Bits, Signed>&, const T&) [with T = wide::integer<256, int>; long unsigned int Bits = 256; Signed = int]’:
/home/fuzhe/projects/tics/libs/libcommon/include/common/wide_integer_impl.h:650:31:   required from ‘static constexpr auto wide::integer<Bits, Signed>::_impl::operator_star(const wide::integer<Bits, Signed>&, const T&) [with T = wide::integer<256, int>; long unsigned int Bits = 256; Signed = int]’
/home/fuzhe/projects/tics/libs/libcommon/include/common/wide_integer_impl.h:1221:100:   required from ‘constexpr std::common_type_t<wide::integer<Bits, Signed>, wide::integer<Bits2, Signed2> > wide::operator*(const wide::integer<Bits, Signed>&, const wide::integer<Bits2, Signed2>&) [with long unsigned int Bits = 256; Signed = int; long unsigned int Bits2 = 256; Signed2 = int; std::common_type_t<wide::integer<Bits, Signed>, wide::integer<Bits2, Signed2> > = wide::integer<256, int>]’
/home/fuzhe/projects/tics/libs/libcommon/include/common/wide_integer_impl.h:1227:20:   required from ‘constexpr std::common_type_t<Arithmetic, Arithmetic2> wide::operator*(const Arithmetic&, const Arithmetic2&) [with Arithmetic = wide::integer<256, int>; Arithmetic2 = int; <template-parameter-1-3> = void; std::common_type_t<Arithmetic, Arithmetic2> = wide::integer<256, int>]’
/home/fuzhe/projects/tics/dbms/src/Common/Decimal.h:205:39:   required from here
/home/fuzhe/projects/tics/libs/libcommon/include/common/wide_integer_impl.h:501:22: error: conversion from ‘const wide::integer<256, int>’ to ‘HalfType {aka __int128 unsigned}’ is ambiguous
             HalfType b01 = rhs;
                      ^~~
```
build pass
f186494
update contrib
a4d744d
Merge branch 'fuzhe/port_ch/base/common' of github.com:fuzhe1989/tics…
aee0535 
… into fuzhe1989-fuzhe/port_ch/base/common
Merge branch 'fuzhe1989-fuzhe/port_ch/base/common' into fuzhe/port_ch…
92178d2 
…/base/common
Merge branch 'master' into fuzhe1989-fuzhe/port_ch/base/common
dfcb723
Merge branch 'fuzhe1989-fuzhe/port_ch/base/common' into fuzhe/port_ch…
4460f7f 
…/base/common
fix build fail
2114113
fix build fail
a2c5920
fix build fail; unittest pass
18dcbfd
@fuzhe1989
Merge branch 'master' into fuzhe/port_ch/base/common
fb72d5f
update
83acc2c
fix build gtest_libcommon fail
0cf0d49
Replace ClickHouse's wide::integer by ckormanyos/wide-integer
059b47a
@fuzhe1989
Merge branch 'master' into fuzhe/port_ch/base/common
900ee0f
rm wide_integer_to_string.h
f2d917f
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 3, 2022
@ti-chi-bot
Copy link
Member

@fuzhe1989: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 3, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 1, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

fuzhe1989 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 26, 2024

@fuzhe1989: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-test f2d917f link true /test pull-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/needs-linked-issue needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fuzhe1989 @ti-chi-bot @sre-bot