-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Fix the bug that castStringAsReal has different behaivor between tiflash and tikv/tidb. #3681
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/524/cobertura/ lines: 42.5% (47535 out of 111818) |
63f6e84
to
5bfbabc
Compare
/merge |
@windtalker: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 183d9d1
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/653/cobertura/ lines: 42.8% (48253 out of 112716) |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #3753. |
In response to a cherrypick label: new pull request created: #3754. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #3755. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #3756. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #3757. |
lines: 42.4% (48240 out of 113815) |
What problem does this PR solve?
Issue Number: close #3475, related to #3447
Problem Summary: Fix the bug that castStringAsReal has different behaivor between tiflash and tikv/tidb.
What is changed and how it works?
truncate string, instead of passing it all to strtod.
Check List
Tests
Side effects
Documentation
Release note