Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push down Left/right to tiflash (#2045) #2076

Merged
merged 7 commits into from
Jun 18, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 3, 2021

cherry-pick #2045 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2076

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2076:release-5.0-6bcde41472b1

What problem does this PR solve?

Issue Number: close ##1943

Problem Summary: push down left/right to tiflash, but only accept constants for the second parameter.

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

Release note

  • push down Left/right to tiflash

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@ti-srebot ti-srebot added this to the v5.0.3 milestone Jun 3, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/run-all-tests

@fzhedu fzhedu requested a review from windtalker June 18, 2021 08:20
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/merge

@ti-srebot
Copy link
Collaborator Author

@fzhedu Oops! This PR requires at least 1 LGTMs to merge. The current number of LGTM is 0

@windtalker
Copy link
Contributor

/lgtm

@windtalker
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-srebot
Copy link
Collaborator Author

Your auto merge job has been accepted, waiting for:

  • 2075

@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/run-all-tests

@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/merge

@ti-srebot
Copy link
Collaborator Author

Your auto merge job has been accepted, waiting for:

  • 2085
  • 1877

@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/run-all-tests

@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/merge

@ti-srebot
Copy link
Collaborator Author

Your auto merge job has been accepted, waiting for:

  • 2085
  • 1877

@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/run-all-tests

@fzhedu fzhedu merged commit 39dbbfe into pingcap:release-5.0 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants