Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page-ctl cannot work when there is an unresolved page ref #5568

Closed
Tracked by #4989
breezewish opened this issue Aug 9, 2022 · 0 comments · Fixed by #6224
Closed
Tracked by #4989

page-ctl cannot work when there is an unresolved page ref #5568

breezewish opened this issue Aug 9, 2022 · 0 comments · Fixed by #6224
Assignees
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@breezewish
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Use write batch to write a page ref that cannot be resolved into PSv3, and then use PageCtl to observe it:

./page-ctl --page_storage_version 3 --paths ../../data/page/meta

2. What did you expect to see? (Required)

PageCtl is able to decode everything and let me observe how invalid ref comes from.

3. What did you see instead (Required)

PageCtl crashed without any readable message:

[1]    28874 abort (core dumped)  LD_LIBRARY_PATH=$(pwd) ./page-ctl --page_storage_version 3 --path

When attached a debugger:

Program received signal SIGABRT, Aborted.
0x00007ffff3837387 in raise () from /lib64/libc.so.6
(gdb) bt
#0  0x00007ffff3837387 in raise () from /lib64/libc.so.6
#1  0x00007ffff3838a78 in abort () from /lib64/libc.so.6
#2  0x0000000000cdb84e in DB::PS::V3::PageStorageControlV3::run (this=<optimized out>, this@entry=0x7fffffffdf40)
    at /root/wenxuan/tiflash/dbms/src/Storages/Page/tools/PageCtl/PageStorageCtlV3.cpp:153
#3  0x0000000000cdace7 in pageStorageV3CtlEntry (argc=<optimized out>, argc@entry=3, argv=<optimized out>, argv@entry=0x7fffffffe258)
    at /root/wenxuan/tiflash/dbms/src/Storages/Page/tools/PageCtl/PageStorageCtlV3.cpp:522
#4  0x0000000000cd488f in DB::PageStorageCtl::mainEntry (argc=<optimized out>, argv=<optimized out>)
    at /root/wenxuan/tiflash/dbms/src/Storages/Page/tools/PageCtl/MainEntry.cpp:48
#5  0x00007ffff3823555 in __libc_start_main () from /lib64/libc.so.6
#6  0x0000000000cd43e9 in _start () at ../sysdeps/x86_64/start.S:123

4. What is your TiFlash version? (Required)

master

@breezewish breezewish added the type/bug The issue is confirmed as a bug. label Aug 9, 2022
CalvinNeo pushed a commit to CalvinNeo/tiflash that referenced this issue Nov 4, 2022
close pingcap#5568

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants