Address comments

Signed-off-by: Wish <breezewish@outlook.com>
pingcap · Mar 3, 2023 · 5a7ad7b · 5a7ad7b
1 parent 3eb30f1
commit 5a7ad7b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/dbms/src/Storages/Page/V3/PageDirectory.cpp b/dbms/src/Storages/Page/V3/PageDirectory.cpp
@@ -516,7 +516,11 @@ void VersionedPageEntries<Trait>::copyCheckpointInfoFromEdit(const typename Page
         return;
     }
 
-    RUNTIME_CHECK(iter->first.sequence == edit.version.sequence); // TODO: If there is a full GC this may be false?
+    // TODO: Not sure if there is a full GC this may be false? Let's keep it here for now.
+    RUNTIME_CHECK(
+        iter->first.sequence == edit.version.sequence,
+        iter->first.sequence,
+        edit.version.sequence);
 
     // Discard epoch, and only check sequence.
     while (iter->first.sequence == edit.version.sequence)

diff --git a/dbms/src/Storages/Page/V3/PageDirectory.h b/dbms/src/Storages/Page/V3/PageDirectory.h
@@ -46,9 +46,6 @@ extern const Metric PSMVCCNumSnapshots;
 namespace DB::PS::V3
 {
 
-class CPWriteDataSource;
-using CPWriteDataSourcePtr = std::shared_ptr<CPWriteDataSource>;
-
 class PageDirectorySnapshot : public DB::PageStorageSnapshot
 {
 public: