Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: move FindIndexByName to parser #9951

Merged
merged 7 commits into from
Apr 1, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

move FindIndexByName to parser.
Please merge parser PR : pingcap/parser#267 first.

@crazycs520
Copy link
Contributor Author

@zz-jason @winkyao PTAL

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2019
@zz-jason
Copy link
Member

zz-jason commented Apr 1, 2019

@crazycs520 Please update the parser version

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Apr 1, 2019

/run-all-tests

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2019
@zz-jason
Copy link
Member

zz-jason commented Apr 1, 2019

/run-integration-common-test

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6125f49). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master      #9951   +/-   ##
===========================================
  Coverage          ?   77.6465%           
===========================================
  Files             ?        403           
  Lines             ?      82296           
  Branches          ?          0           
===========================================
  Hits              ?      63900           
  Misses            ?      13680           
  Partials          ?       4716

@zz-jason zz-jason merged commit 873d951 into pingcap:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants