-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: move FindIndexByName to parser #9951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crazycs520 Please update the parser version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-integration-common-test |
Codecov Report
@@ Coverage Diff @@
## master #9951 +/- ##
===========================================
Coverage ? 77.6465%
===========================================
Files ? 403
Lines ? 82296
Branches ? 0
===========================================
Hits ? 63900
Misses ? 13680
Partials ? 4716 |
What problem does this PR solve?
move FindIndexByName to parser.
Please merge parser PR : pingcap/parser#267 first.