Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edit to intro paragraph #9944

Merged
merged 3 commits into from
Mar 30, 2019
Merged

Minor edit to intro paragraph #9944

merged 3 commits into from
Mar 30, 2019

Conversation

ceohockey60
Copy link
Contributor

Minor edit to intro paragraph, so it's less repetitive.

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Minor edit to intro paragraph, so it's less repetitive.
@ceohockey60
Copy link
Contributor Author

@morgo PTAL. thank you.

@morgo morgo self-requested a review March 28, 2019 22:18
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo
Copy link
Contributor

morgo commented Mar 28, 2019

@kolbe PTAL

Copy link
Contributor

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8e0cfc2). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master      #9944   +/-   ##
===========================================
  Coverage          ?   77.5531%           
===========================================
  Files             ?        404           
  Lines             ?      81722           
  Branches          ?          0           
===========================================
  Hits              ?      63378           
  Misses            ?      13642           
  Partials          ?       4702

@morgo
Copy link
Contributor

morgo commented Mar 29, 2019

/run-all-tests

@zz-jason zz-jason merged commit a3ff679 into master Mar 30, 2019
@zz-jason zz-jason deleted the ceohockey60-patch-1 branch March 30, 2019 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants