Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update parser version and add unit test #9928

Merged
merged 2 commits into from
Mar 28, 2019
Merged

go.mod: update parser version and add unit test #9928

merged 2 commits into from
Mar 28, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Mar 28, 2019 •
edited
Loading

What problem does this PR solve?

parser's pr pingcap/parser#264 fix issue #9910
need update parser's version
same with #9917

What is changed and how it works?

update parser's version in go.mod

Check List

Tests

  • Manual test (Manual test (create table, with column named node_id and node_state))

@WangXiangUSTC WangXiangUSTC changed the title update parser version and add unit test go.mog: update parser version and add unit test Mar 28, 2019
winkyao
winkyao reviewed Mar 28, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Mar 28, 2019

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

crazycs520
crazycs520 approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao changed the title go.mog: update parser version and add unit test go.mod: update parser version and add unit test Mar 28, 2019
@kennytm kennytm added status/LGT2 Indicates that a PR has LGTM 2. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Mar 28, 2019
@zz-jason zz-jason merged commit 542af77 into pingcap:release-2.1 Mar 28, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/update_parser branch March 28, 2019 05:53
@kennytm kennytm mentioned this pull request Mar 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WangXiangUSTC @winkyao @crazycs520 @kennytm @zz-jason