Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: check more errors in test. #9859

Merged
merged 3 commits into from
Mar 24, 2019
Merged

*: check more errors in test. #9859

merged 3 commits into from
Mar 24, 2019

Conversation

xiekeyi98
Copy link
Contributor

What problem does this PR solve?

Check more errors in the test.

What is changed and how it works?

Check errors when the function return error.

Check List

Tests

  • Unit test
  • Integration test

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #9859 into master will increase coverage by 0.0037%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #9859        +/-   ##
================================================
+ Coverage   67.3512%   67.3549%   +0.0037%     
================================================
  Files           383        383                
  Lines         80444      80444                
================================================
+ Hits          54180      54183         +3     
+ Misses        21421      21417         -4     
- Partials       4843       4844         +1

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2019
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiekeyi98
Copy link
Contributor Author

/run-all-tests

@xiekeyi98
Copy link
Contributor Author

/run-unit-test

@xiekeyi98 xiekeyi98 merged commit 5ed3553 into pingcap:master Mar 24, 2019
@xiekeyi98 xiekeyi98 deleted the checkallerrors branch March 24, 2019 08:16
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants