Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support create global binding #9846

Merged
merged 54 commits into from
Apr 17, 2019

Conversation

iamzhoug37
Copy link
Contributor

@iamzhoug37 iamzhoug37 commented Mar 21, 2019

What problem does this PR solve?

Associated iusse: #8935

What is changed and how it works?

feature: support add global binding
use case:
create table t(i int, s varchar(20)) create index index_t on t(i,s)
If we want to add index hint bind for select * from t, we just execute create global binding for select * from t using select * from t use index for join(index_t).

Check List

Tests

  • Unit test
  • Integration test

Code changes
N/A

Side effects

N/A

Related changes
N/A

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #9846 into master will decrease coverage by 0.0253%.
The diff coverage is 75.2688%.

@@               Coverage Diff                @@
##             master      #9846        +/-   ##
================================================
- Coverage   78.0196%   77.9943%   -0.0254%     
================================================
  Files           405        406         +1     
  Lines         82169      82338       +169     
================================================
+ Hits          64108      64219       +111     
- Misses        13352      13390        +38     
- Partials       4709       4729        +20

session/session.go Outdated Show resolved Hide resolved
planner/core/planbuilder.go Outdated Show resolved Hide resolved
session/session.go Outdated Show resolved Hide resolved
@zz-jason zz-jason added contribution This PR is from a community contributor. type/new-feature labels Mar 23, 2019
session/bootstrap.go Outdated Show resolved Hide resolved
executor/bind.go Outdated Show resolved Hide resolved
executor/bind.go Outdated Show resolved Hide resolved
executor/bind.go Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2019

CLA assistant check
All committers have signed the CLA.

@iamzhoug37 iamzhoug37 force-pushed the plan-management-add-global-binding branch from 47eee3b to 5aa25ef Compare March 28, 2019 03:23
session/session.go Outdated Show resolved Hide resolved
session/session.go Outdated Show resolved Hide resolved
bindinfo/cache.go Outdated Show resolved Hide resolved
executor/bind.go Outdated Show resolved Hide resolved
bindinfo/cache.go Outdated Show resolved Hide resolved
bindinfo/cache.go Outdated Show resolved Hide resolved
bindinfo/bind.go Outdated Show resolved Hide resolved
executor/bind.go Outdated Show resolved Hide resolved
bindinfo/cache.go Outdated Show resolved Hide resolved
bindinfo/cache.go Outdated Show resolved Hide resolved
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

@lamxTyler @qw4990 @XuHuaiyu PTAL

@zz-jason
Copy link
Member

/run-all-tests

bindinfo/handle.go Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 17, 2019
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason changed the title sql plan management: support add global binding *: support create global binding Apr 17, 2019
@zz-jason zz-jason merged commit 63d720c into pingcap:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants