-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support create global binding #9846
Merged
zz-jason
merged 54 commits into
pingcap:master
from
iamzhoug37:plan-management-add-global-binding
Apr 17, 2019
Merged
*: support create global binding #9846
zz-jason
merged 54 commits into
pingcap:master
from
iamzhoug37:plan-management-add-global-binding
Apr 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9846 +/- ##
================================================
- Coverage 78.0196% 77.9943% -0.0254%
================================================
Files 405 406 +1
Lines 82169 82338 +169
================================================
+ Hits 64108 64219 +111
- Misses 13352 13390 +38
- Partials 4709 4729 +20 |
alivxxx
reviewed
Mar 21, 2019
zz-jason
added
contribution
This PR is from a community contributor.
type/new-feature
labels
Mar 23, 2019
alivxxx
reviewed
Mar 25, 2019
iamzhoug37
force-pushed
the
plan-management-add-global-binding
branch
from
March 28, 2019 03:23
47eee3b
to
5aa25ef
Compare
alivxxx
reviewed
Mar 28, 2019
alivxxx
reviewed
Apr 1, 2019
alivxxx
reviewed
Apr 1, 2019
alivxxx
reviewed
Apr 1, 2019
shenli
reviewed
Apr 1, 2019
zz-jason
reviewed
Apr 16, 2019
…oug37/tidb into plan-management-add-global-binding
…oug37/tidb into plan-management-add-global-binding
zz-jason
reviewed
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
alivxxx
reviewed
Apr 17, 2019
alivxxx
reviewed
Apr 17, 2019
…oug37/tidb into plan-management-add-global-binding
alivxxx
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alivxxx
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Apr 17, 2019
/run-all-tests |
zz-jason
changed the title
sql plan management: support add global binding
*: support create global binding
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution
This PR is from a community contributor.
status/LGT2
Indicates that a PR has LGTM 2.
type/new-feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Associated iusse: #8935
What is changed and how it works?
feature: support add global binding
use case:
create table t(i int, s varchar(20)) create index index_t on t(i,s)
If we want to add index hint bind for
select * from t
, we just executecreate global binding for select * from t using select * from t use index for join(index_t)
.Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes
N/A