planner/core: fix privilege check for grant on table #9828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pingcap#9781 In this SQL: GRANT SELECT ON t1 TO 'nonsuper', the database name of visit info should be set to current database.
Codecov Report
@@ Coverage Diff @@
## master #9828 +/- ##
================================================
+ Coverage 67.4095% 67.4191% +0.0095%
================================================
Files 383 383
Lines 80137 80139 +2
================================================
+ Hits 54020 54029 +9
+ Misses 21289 21284 -5
+ Partials 4828 4826 -2 |
|
LGTM |
|
/run-all-tests |
|
LGTM |
|
@tiancaiamao Do we need to cherry-pick this to the release-2.1? |
|
/run-all-tests Ok,I'll do it @shenli |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Mar 22, 2019
Fix pingcap#9781 In this SQL: GRANT SELECT ON t1 TO 'nonsuper', the database name of visit info should be set to current database.
zz-jason
pushed a commit
that referenced
this pull request
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9781
What is changed and how it works?
In this SQL:
GRANT SELECT ON t1 TO 'nonsuper',the database name of visit info should be set to current database.
Check List
Tests