*: replace interface{} with Datum in convert. #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -19,6 +19,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/pingcap/check" | |||
| "github.com/pingcap/tidb/Godeps/_workspace/src/github.com/juju/errors" | |||
There was a problem hiding this comment.
"github.com/pingcap/tidb/Godeps/_workspace/src/github.com/juju/errors" -> "github.com/juju/errors" ？
coocood
force-pushed
the
coocood/datum-convert
branch
from
5bc5a50 to
6bea1d6
Compare
| case KindMysqlSet: | ||
| dec = mysql.NewDecimalFromFloat(d.GetMysqlSet().ToNumber()) | ||
| default: | ||
| return ret, fmt.Errorf("can't convert %v to decimal", d) |
There was a problem hiding this comment.
return invalidConv(d, target.Tp)？
coocood
force-pushed
the
coocood/datum-convert
branch
2 times, most recently
from
13ef1e9 to
388f7c3
Compare
|
LGTM |
coocood
force-pushed
the
coocood/datum-convert
branch
from
388f7c3 to
ac12b71
Compare
coocood
added a commit
that referenced
this pull request
Mar 7, 2016
*: replace interface{} with Datum in convert.
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.