-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server, sessionctx: workaround var initialization #9383
Conversation
Set variable values on server start
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9383 +/- ##
==========================================
+ Coverage 67.16% 67.17% +0.01%
==========================================
Files 373 373
Lines 78269 78269
==========================================
+ Hits 52567 52580 +13
+ Misses 20995 20986 -9
+ Partials 4707 4703 -4
Continue to review full report at Codecov.
|
LGTM |
@jackysp thanks for the suggestion, I've moved it. PTAL again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What problem does this PR solve?
This provides a workaround for #9382
I suggest a longer-term fix here: #9381
What is changed and how it works?
This makes various sysvars work:
Port was previously added in #9365 , but it turns out this did not work correctly since it retrieved the 'default' port prior to parsing the config file. I have changed the value to be "4000" in variables so it becomes less confusing since this doesn't work.
Check List
Tests
The test-suite contains the server variables from the default config only, and so it is difficult to assert for these changes.
Code changes
Side effects
Related changes