Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: implement skyline pruning #9337

Merged
merged 16 commits into from
Feb 19, 2019
Merged
Prev Previous commit
Next Next commit
address comments
  • Loading branch information
alivxxx committed Feb 18, 2019
commit aa72d5730cab5f388ff43210577a112c7ece3f39
2 changes: 1 addition & 1 deletion expression/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func extractColumns(result []*Column, expr Expression, filter func(*Column) bool
return result
}

// ExtractColumnSet extract the different unique id of columns that occurred in the exprs.
// ExtractColumnSet extracts the different values of `UniqueId` for columns in expressions.
func ExtractColumnSet(exprs []Expression) *intsets.Sparse {
zz-jason marked this conversation as resolved.
Show resolved Hide resolved
set := &intsets.Sparse{}
for _, expr := range exprs {
Expand Down