Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add integration tests for access path selection #9212

Merged
merged 10 commits into from
Feb 18, 2019
Merged

add integration tests for access path selection #9212

merged 10 commits into from
Feb 18, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jan 29, 2019

What problem does this PR solve?

Add two integration tests for access path selection.

What is changed and how it works?

Add two files access_path_selection.text and access_path_selection.result to store test SQL and results correspondingly.

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

@qw4990 qw4990 added the sig/planner SIG: Planner label Jan 29, 2019
@qw4990 qw4990 self-assigned this Jan 29, 2019
@codecov-io
Copy link

codecov-io commented Jan 29, 2019 •
edited
Loading

Codecov Report

Merging #9212 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9212      +/-   ##
==========================================
+ Coverage   67.17%   67.17%   +<.01%     
==========================================
  Files         372      372              
  Lines       77656    77656              
==========================================
+ Hits        52162    52165       +3     
+ Misses      20834    20832       -2     
+ Partials     4660     4659       -1
Impacted Files Coverage Δ
store/tikv/lock_resolver.go 41.7% <0%> (-0.95%) ⬇️
expression/schema.go 93.75% <0%> (-0.79%) ⬇️
ddl/delete_range.go 79.36% <0%> (+1.58%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a333cfb...0e55e56. Read the comment docs.

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 14, 2019

PTAL~ @winoros @lamxTyler

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 14, 2019

Add a more wrong index selection case. PTAL~ @lamxTyler

alivxxx
alivxxx reviewed Feb 14, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Feb 15, 2019

One more bad case involving unknown correlation between columns has been added.
PTAL~ @lamxTyler @eurekaka

@qw4990 qw4990 requested a review from eurekaka February 15, 2019 11:20
eurekaka
eurekaka reviewed Feb 18, 2019
View reviewed changes
cmd/explaintest/r/access_path_selection.result Outdated Show resolved Hide resolved
cmd/explaintest/r/access_path_selection.result Outdated Show resolved Hide resolved
cmd/explaintest/t/access_path_selection.test Outdated Show resolved Hide resolved
cmd/explaintest/t/access_path_selection.test Show resolved Hide resolved
eurekaka
eurekaka approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor

/run-all-tests

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 18, 2019
@alivxxx alivxxx mentioned this pull request Feb 18, 2019
Merged
@qw4990 qw4990 merged commit 7c0a9a7 into pingcap:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@alivxxx alivxxx alivxxx left review comments

@eurekaka eurekaka eurekaka approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees

@qw4990 qw4990

Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qw4990 @codecov-io @eurekaka @winoros @alivxxx @zz-jason