Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Support grant stmt in new plan. #905

Merged
merged 1 commit into from
Feb 17, 2016
Merged

*: Support grant stmt in new plan. #905

merged 1 commit into from
Feb 17, 2016

Conversation

shenli
Copy link
Member

@shenli shenli commented Feb 17, 2016

coocood
coocood reviewed Feb 17, 2016
View reviewed changes
executor/converter/convert_stmt.go
@@ -918,3 +919,4 @@ func convertGrant(converter *expressionConverter, v *ast.GrantStmt) (*stmts.Gran
}
return oldGrant, nil
}
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove those lines.

@shenli
Copy link
Member Author

shenli commented Feb 17, 2016

PTAL @coocood @qiuyesuifeng

@coocood
Copy link
Member

coocood commented Feb 17, 2016

LGTM

1 similar comment
@qiuyesuifeng
Copy link
Member

LGTM

shenli added a commit that referenced this pull request Feb 17, 2016
@shenli
Merge pull request #905 from pingcap/shenli/grant
0ff85e7 
*: Support grant stmt in new plan.
@shenli shenli merged commit 0ff85e7 into master Feb 17, 2016
@shenli shenli deleted the shenli/grant branch February 17, 2016 07:27
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
@glorv
pkg/lightning: let batch split keys also consider the raft entry limit (
4243361 
pingcap#905)
xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021
@AilinKid
[parser] parser: fix signed num will parse error when it encounter tw…
341d5f5 
…o's complement min (pingcap#905)
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
@AilinKid @xhebox
[parser] parser: fix signed num will parse error when it encounter tw…
b6db94f 
…o's complement min (pingcap#905)
ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021
@AilinKid @ti-chi-bot
[parser] parser: fix signed num will parse error when it encounter tw…
b5dafb9 
…o's complement min (#905)
rleungx pushed a commit to rleungx/tidb that referenced this pull request Mar 12, 2024
@AmoebaProtozoa
make tidb-enable-dist-task an config instead of a variable (pingcap…
79cdf56 
…#905)

* add force dist task option

Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>

* make enable dist task controlled by setting

Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>

---------

Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shenli @coocood @qiuyesuifeng