Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add SHOW CREATE USER syntax #8970

Merged
merged 13 commits into from
Jan 9, 2019
Merged

parser: add SHOW CREATE USER syntax #8970

merged 13 commits into from
Jan 9, 2019

Conversation

lnhote
Copy link
Contributor

@lnhote lnhote commented Jan 7, 2019 •
edited by c4pt0r
Loading

What problem does this PR solve?

parser PR: pingcap/parser#156
parser issue: pingcap/parser#137

What is changed and how it works?

  1. add a new type for ShowStmt
  2. update parser.y and parser.go

Check List

Tests

  • Unit test

Code changes

  • add new const: ast.ShowCreateUser

This change is Reviewable

@morgo morgo added contribution This PR is from a community contributor. component/parser labels Jan 8, 2019
@zz-jason
Copy link
Member

zz-jason commented Jan 8, 2019

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Jan 8, 2019

@lnhote pingcap/parser#156 is merged, could you update this PR to point to the latest "pingcap/parser" branch so that we can carry on this PR?

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zz-jason
Copy link
Member

zz-jason commented Jan 8, 2019

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Jan 8, 2019
alivxxx
alivxxx reviewed Jan 8, 2019
View reviewed changes
go.sum Outdated Show resolved Hide resolved
XuHuaiyu
XuHuaiyu reviewed Jan 8, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed, please run GO111MODULE=on go mod tidy

@codecov-io
Copy link

codecov-io commented Jan 8, 2019 •
edited
Loading

Codecov Report

Merging #8970 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8970      +/-   ##
==========================================
+ Coverage   67.55%   67.55%   +<.01%     
==========================================
  Files         363      363              
  Lines       75301    75301              
==========================================
+ Hits        50870    50873       +3     
  Misses      19937    19937              
+ Partials     4494     4491       -3
Impacted Files Coverage Δ
ddl/delete_range.go 74.28% <0%> (-4.58%) ⬇️
expression/schema.go 94.11% <0%> (-0.85%) ⬇️
executor/join.go 78.7% <0%> (+0.81%) ⬆️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️
store/mockstore/mocktikv/pd.go 58.97% <0%> (+7.69%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f209843...af652f9. Read the comment docs.

@zz-jason zz-jason requested review from XuHuaiyu and alivxxx January 8, 2019 15:10
alivxxx
alivxxx approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 9, 2019
@alivxxx alivxxx removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 9, 2019
@zz-jason zz-jason merged commit bb2d56a into pingcap:master Jan 9, 2019
@morgo morgo mentioned this pull request Jan 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/parser contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lnhote @zz-jason @CLAassistant @codecov-io @XuHuaiyu @alivxxx @morgo