Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING: '/' -> '/' #8954

Merged
merged 4 commits into from
Jan 7, 2019
Merged

CONTRIBUTING: '/' -> '/' #8954

merged 4 commits into from
Jan 7, 2019

Conversation

invzhi
Copy link
Contributor

@invzhi invzhi commented Jan 5, 2019

What problem does this PR solve?

Improve documentation.

What is changed and how it works?

-> / in CONTRIBUTING.md

Check List

Tests

  • No code

Code changes

  • No Code changes

Side effects

  • No Side effects

Related changes

  • No Related changes

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2019

CLA assistant check
All committers have signed the CLA.

@zz-jason zz-jason added contribution This PR is from a community contributor. component/docs labels Jan 5, 2019
@codecov-io
Copy link

codecov-io commented Jan 5, 2019

Codecov Report

Merging #8954 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8954      +/-   ##
==========================================
- Coverage   67.53%   67.52%   -0.02%     
==========================================
  Files         363      363              
  Lines       75199    75199              
==========================================
- Hits        50787    50778       -9     
- Misses      19931    19936       +5     
- Partials     4481     4485       +4
Impacted Files Coverage Δ
ddl/delete_range.go 74.28% <0%> (-4.58%) ⬇️
expression/schema.go 94.11% <0%> (-0.85%) ⬇️
executor/executor.go 66.76% <0%> (-0.29%) ⬇️
executor/join.go 76.27% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b02455...e6db02a. Read the comment docs.

@@ -15,7 +15,7 @@ A Contributor refers to the person who contributes to the following projects:

## How to become a TiDB Contributor?

If a PR (Pull Request) submitted to the TiDB / TiKV / TiSpark / PD / Docs/Docs-cn projects by you is approved and merged, then you become a TiDB Contributor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "TiDB/TiKV/TiSpark/PD/Docs/Docs-cn" is better.
@queenypingcap PTAL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from XuHuaiyu January 7, 2019 11:06
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2019
@zz-jason zz-jason requested a review from alivxxx January 7, 2019 11:39
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 8468e7e into pingcap:master Jan 7, 2019
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 7, 2019
@invzhi invzhi deleted the doc branch January 8, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/docs contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants