Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support "or replace" option when create view #8856

Merged
merged 32 commits into from
Jan 16, 2019
Merged

ddl: support "or replace" option when create view #8856

merged 32 commits into from
Jan 16, 2019

Conversation

AndrewDi
Copy link
Contributor

@AndrewDi AndrewDi commented Dec 28, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

Implement or replace flag during create view.

What is changed and how it works?

ref proposal Proposal: Implement View

Check List

Tests

  • Unit test

This change is Reviewable

@AndrewDi AndrewDi force-pushed the view/create_or_replace branch from bd53a28 to 7cc3460 Compare December 28, 2018 01:09
@XuHuaiyu
Copy link
Contributor

Please add the link of the related issue in the description.

@XuHuaiyu XuHuaiyu added contribution This PR is from a community contributor. type/new-feature labels Dec 28, 2018
@AndrewDi AndrewDi mentioned this pull request Dec 28, 2018
Closed
19 tasks
zimulala
zimulala reviewed Dec 28, 2018
View reviewed changes
@zhouqiang-cl
Copy link
Contributor

/rebuild

winkyao
winkyao reviewed Dec 28, 2018
View reviewed changes
@AndrewDi
Copy link
Contributor Author

/run-all-tests

@AndrewDi
Copy link
Contributor Author

AndrewDi commented Jan 2, 2019

@zimulala @winkyao PTAL

zz-jason
zz-jason reviewed Jan 5, 2019
View reviewed changes
@zz-jason zz-jason changed the title ddl: create view support or_replace flag ddl: support "or replace" option when create view Jan 5, 2019
@AndrewDi AndrewDi force-pushed the view/create_or_replace branch from 8ec474a to 5ae5902 Compare January 5, 2019 14:06
zz-jason
zz-jason reviewed Jan 5, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 5, 2019
@zz-jason
Copy link
Member

/run-all-tests tidb-test=pr/716

@AndrewDi
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor

/run-all-tests

1 similar comment
@crazycs520
Copy link
Contributor

/run-all-tests

crazycs520
crazycs520 reviewed Jan 14, 2019
View reviewed changes
@crazycs520
Copy link
Contributor

/run-all-tests

crazycs520
crazycs520 reviewed Jan 16, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewDi
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor

@crazycs520 Already 3 LGTM, can this PR be approved?

@crazycs520 crazycs520 added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 16, 2019
@ngaut ngaut removed the status/LGT2 Indicates that a PR has LGTM 2. label Jan 16, 2019
@ngaut ngaut merged commit f522de2 into pingcap:master Jan 16, 2019
@AndrewDi AndrewDi deleted the view/create_or_replace branch January 16, 2019 12:21
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winkyao winkyao winkyao left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@crazycs520 crazycs520 crazycs520 left review comments

@ngaut ngaut ngaut approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@AndrewDi @XuHuaiyu @zhouqiang-cl @zz-jason @codecov-io @crazycs520 @ngaut @zimulala @winkyao @you06