*: remove fail field from TxnState (#8712)
#8764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, fail is added to simplify error handling, avoiding large changes on the Txn() interface API. But it turns out that fail introduces complexity. So this commit removes the fail and makes an API refactoring.
|
/run-all-tests tidb-test=pr/708 |
|
/run-all-tests tidb-test=pr/708 |
1 similar comment
|
/run-all-tests tidb-test=pr/708 |
tiancaiamao
force-pushed
the
cherry-2.0
branch
from
6e6ef27 to
3b44646
Compare
|
/run-all-tests tidb-test=pr/708 |
|
/rebuild |
|
/run-all-tests tidb-test=pr/708 |
lysu
added
require-LGT3
|
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
|
/run-integration-ddl-test tidb-test=pr/708 tikv=release-2.0 pd=release-2.0 |
tiancaiamao
added a commit
that referenced
this pull request
Jan 2, 2019
This reverts commit 305a083.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick from #8712
Please review session.go carefully.
@lysu @winkyao @jackysp
This change is