Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add unit test for aggfuncs (#7966) #8450

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Nov 26, 2018

cherry-pick #7966


This change is Reviewable

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. sig/execution SIG execution labels Nov 26, 2018
@XuHuaiyu
Copy link
Contributor Author

/run-unit-test tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit 3232c8a into pingcap:release-2.1 Nov 26, 2018
@XuHuaiyu XuHuaiyu deleted the cherry-pick-agg-test-2.1 branch November 26, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants