*: add a variable tidb_slow_log_threshold to set the slow log threshold dynamically #8094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
reviewed
Oct 29, 2018
lysu
reviewed
Oct 29, 2018
| @@ -85,6 +85,8 @@ func GetSessionOnlySysVars(s *SessionVars, key string) (string, bool, error) { | |||
| return string(j), true, nil | |||
| case TiDBForcePriority: | |||
| return mysql.Priority2Str[mysql.PriorityEnum(atomic.LoadInt32(&ForcePriority))], true, nil | |||
| case TiDBSlowLogThreshold: | |||
| return strconv.FormatUint(atomic.LoadUint64(&config.GetGlobalConfig().Log.SlowThreshold), 10), true, nil | |||
There was a problem hiding this comment.
IMHO, adapator.go:351 also need change to atomic.LoadUnit64 to keep visibility guarantee?
|
LGTM. I like that it is in |
|
PTAL @lysu |
|
LGTM |
jackysp
added
type/enhancement
|
Won't support this until we support https://dev.mysql.com/doc/refman/8.0/en/persisted-system-variables.html. |
|
/run-all-tests |
XuHuaiyu
approved these changes
Nov 5, 2018
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Nov 5, 2018
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Changing the slow log threshold in TiDB needs to reboot the server to affect.
What is changed and how it works?
Add a variable "tidb_slow_log_threshold" to set the threshold by SQL.
Check List
Tests
Code changes
Has exported function/method change
Need to cherry-pick to the release branch
PTAL @tiancaiamao @lysu