Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix driver panic #78

Merged
merged 3 commits into from
Sep 9, 2015
Merged

fix driver panic #78

merged 3 commits into from
Sep 9, 2015

Conversation

siddontang
Copy link
Member

fix panic when running tests in https://github.com/go-xorm/tidb

go func() {
// We may change the whole implementation later, so here just using WaitGroup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add TODO:

@ngaut
Copy link
Member

ngaut commented Sep 9, 2015

LGTM

1 similar comment
@shenli
Copy link
Member

shenli commented Sep 9, 2015

LGTM

shenli added a commit that referenced this pull request Sep 9, 2015
@shenli shenli merged commit 229f8ed into master Sep 9, 2015
@shenli shenli deleted the siddontang/fix-driver-panic branch September 9, 2015 04:45
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
okJiang pushed a commit to okJiang/tidb that referenced this pull request Oct 19, 2021
* check rows error after dump

* add unit test

* fix csv row error

Co-authored-by: kennytm <kennytm@gmail.com>
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Oct 31, 2022
* add ks metrics label

Signed-off-by: ystaticy <y_static_y@sina.com>
nolouch pushed a commit to tidblabs/tidb that referenced this pull request Jan 6, 2023
…ap#144 into keyspace on release 6.4  (pingcap#161)

* Merge PR pingcap#78,pingcap#79,pingcap#82,pingcap#83,pingcap#86,pingcap#144 into keyspace on release 6.4

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* make check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* make check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix error

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix comment

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* make check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants