address comment

executor/adapter.go

@@ -381,6 +381,12 @@ func (a *ExecStmt) logSlowQuery(txnTS uint64, succ bool) {
 		if user != nil {
 			userString = user.String()
 		}
+		if len(tableIDs) > 10 {
+			tableIDs = tableIDs[10 : len(tableIDs)-1] // Remove "table_ids:" and the last ","
+		}
+		if len(indexIDs) > 10 {
+			indexIDs = indexIDs[10 : len(indexIDs)-1] // Remove "index_ids:" and the last ","
+		}
 		domain.GetDomain(a.Ctx).LogSlowQuery(&domain.SlowQueryInfo{
 			SQL:      sql,
 			Start:    a.startTime,

executor/show_test.go

@@ -637,11 +637,31 @@ func (s *testSuite) TestShowTableStatus(c *C) {
  		partition by range(a)
  		( partition p0 values less than (10),
 		  partition p1 values less than (20),
-    	  partition p2 values less than (maxvalue)
+		  partition p2 values less than (maxvalue)
   		);`)
 	rs, err = tk.Exec("show table status from test like 'tp';")
 	c.Assert(errors.ErrorStack(err), Equals, "")
 	rows, err = session.GetRows4Test(context.Background(), tk.Se, rs)
 	c.Assert(errors.ErrorStack(err), Equals, "")
 	c.Assert(rows[0].GetString(16), Equals, "partitioned")
 }
+
+func (s *testSuite) TestShowSlow(c *C) {
+	tk := testkit.NewTestKit(c, s.store)
+	tk.MustExec("use test")
+	tk.MustExec(`drop table if exists t`)
+	tk.MustExec(`create table t(a bigint)`)
+	tk.MustQuery(`select sleep(1)`)
+
+	result := tk.MustQuery(`admin show slow recent 3`)
+	c.Check(result.Rows(), HasLen, 1)
+
+	result = tk.MustQuery(`admin show slow top 3`)
+	c.Check(result.Rows(), HasLen, 1)
+
+	result = tk.MustQuery(`admin show slow top internal 3`)
+	c.Check(result.Rows(), HasLen, 0)
+
+	result = tk.MustQuery(`admin show slow top all 3`)
+	c.Check(result.Rows(), HasLen, 1)
+}

planner/core/planbuilder.go

@@ -758,7 +758,7 @@ func buildShowSlowSchema() *expression.Schema {
 	schema.Append(buildColumn("", "DETAILS", mysql.TypeVarchar, 256))
 	schema.Append(buildColumn("", "SUCC", mysql.TypeTiny, 2))
 	schema.Append(buildColumn("", "CONN_ID", mysql.TypeLonglong, 4))
-	schema.Append(buildColumn("", "TXNTS", mysql.TypeLonglong, 4))
+	schema.Append(buildColumn("", "TRANSACTION_TS", mysql.TypeLonglong, 4))
 	schema.Append(buildColumn("", "USER", mysql.TypeVarchar, 32))
 	schema.Append(buildColumn("", "DB", mysql.TypeVarchar, 64))
 	schema.Append(buildColumn("", "TABLE_IDS", mysql.TypeVarchar, 64))