*: change package name from plan to planner
#7760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
zz-jason
added
type/enhancement
|
Please update the PR title. |
winoros
changed the title
plan to planner
winoros
reviewed
Sep 21, 2018
zz-jason
added
the
priority/release-blocker
eurekaka
reviewed
Sep 21, 2018
executor/builder.go
Outdated
| @@ -1738,27 +1738,27 @@ func (b *executorBuilder) buildIndexLookUpReader(v *plan.PhysicalIndexLookUpRead | |||
| // dataReaderBuilder build an executor. | |||
| // The executor can be used to read data in the ranges which are constructed by datums. | |||
| // Differences from executorBuilder: | |||
| // 1. dataReaderBuilder calculate data range from argument, rather than plan. | |||
| // 1. dataReaderBuilder calculate data range from argument, rather than core. | |||
executor/builder.go
Outdated
| @@ -1821,7 +1821,7 @@ func (builder *dataReaderBuilder) buildIndexLookUpReaderForIndexJoin(ctx context | |||
| return e, errors.Trace(err) | |||
| } | |||
|
|
|||
| // buildKvRangesForIndexJoin builds kv ranges for index join when the inner plan is index scan plan. | |||
| // buildKvRangesForIndexJoin builds kv ranges for index join when the inner plan is index scan core. | |||
executor/union_scan.go
Outdated
| @@ -103,7 +103,7 @@ type UnionScanExec struct { | |||
| conditions []expression.Expression | |||
| columns []*model.ColumnInfo | |||
|
|
|||
| // belowHandleIndex is the handle's position of the below scan plan. | |||
| // belowHandleIndex is the handle's position of the below scan planner. | |||
expression/expr_to_pb.go
Outdated
| @@ -66,7 +66,7 @@ func ExpressionsToPB(sc *stmtctx.StatementContext, exprs []Expression, client kv | |||
| return | |||
| } | |||
|
|
|||
| // ExpressionsToPBList converts expressions to tipb.Expr list for new plan. | |||
| // ExpressionsToPBList converts expressions to tipb.Expr list for new planner. | |||
planner/core/common_plans.go
Outdated
| @@ -102,14 +102,14 @@ type ChecksumTable struct { | |||
| Tables []*ast.TableName | |||
| } | |||
|
|
|||
| // CancelDDLJobs represents a cancel DDL jobs plan. | |||
| // CancelDDLJobs represents a cancel DDL jobs planner. | |||
planner/core/task.go
Outdated
| @@ -43,7 +43,7 @@ type copTask struct { | |||
| indexPlan PhysicalPlan | |||
| tablePlan PhysicalPlan | |||
| cst float64 | |||
| // indexPlanFinished means we have finished index plan. | |||
| // indexPlanFinished means we have finished index planner. | |||
planner/core/task.go
Outdated
| // If all columns in topN are from index plan, we can push it to index plan. Or we finish the index plan and | ||
| // push it to table plan. | ||
| // If all columns in topN are from index plan, we can push it to index planner. Or we finish the index plan and | ||
| // push it to table planner. |
planner/core/trace.go
Outdated
|
|
||
| import ( | ||
| "github.com/pingcap/tidb/ast" | ||
| ) | ||
|
|
||
| // Trace represents a trace plan. | ||
| // Trace represents a trace planner. |
sessionctx/variable/session.go
Outdated
| PlanID int | ||
|
|
||
| // PlanColumnID is the unique id for column when building plan. | ||
| // PlanColumnID is the unique id for column when building planner. |
| @@ -20,7 +20,7 @@ import ( | |||
| "github.com/pingcap/tidb/types" | |||
| ) | |||
|
|
|||
| // conditionChecker checks if this condition can be pushed to index plan. | |||
| // conditionChecker checks if this condition can be pushed to index planner. | |||
| type conditionChecker struct { | |||
|
/run-all-tests |
winoros
reviewed
Sep 21, 2018
executor/adapter.go
Outdated
| @@ -155,11 +155,11 @@ func (a *ExecStmt) IsPrepared() bool { | |||
|
|
|||
| // IsReadOnly returns true if a statement is read only. | |||
| // It will update readOnlyCheckStmt if current ExecStmt can be conveted to | |||
| // a plan.Execute. Last step is using ast.IsReadOnly function to determine | |||
| // a core.Execute. Last step is using ast.IsReadOnly function to determine | |||
There was a problem hiding this comment.
Oh, it used outside the planner package. What about import it as plancore when its outside the planner package?
|
/run-all-tests |
|
/run-unit-test |
|
@zz-jason Please resolve the conflicts. |
…n-changeto-planner
|
/run-all-tests |
|
/run-integration-ddl-test |
|
/run-integration-ddl-test tidb-test=pr/628 |
|
LGTM |
…n-changeto-planner
eurekaka
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR makes the following two package changes:
The propose of this PR is to:
What is changed and how it works?
almost all the code changes are made by the shell scripts
Check List
Tests