executor: fix lost insert row when insert multi rows on duplicate key update #7685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please paste the original PR link here? |
|
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
|
LGTM |
|
Done, @shenli . |
|
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
zhexuany
approved these changes
Sep 14, 2018
|
/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 |
coocood
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the same bug on release-2.0 as #7675.
When the table has two or more unique index and its primary key is int type, the statement with three rows, the second and third rows conflict with the first one but with different indices. The second row will update the first row, but it deletes the dupKV map with itself by mistake. It will cause a fake update instead of insert without conflicts. See the test case in this PR as an example.
What is changed and how it works?
Delete the correct keys in dupKV map.
Check List
Tests
Code changes
Side effects
PTAL @coocood