Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl:fix type bit could have null as its default value #7604

Merged
merged 6 commits into from
Sep 5, 2018
Merged

ddl:fix type bit could have null as its default value #7604

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50a49b2
ddl:fix type bit could have null as its default value
ciscoxll Sep 4, 2018
96c9f8a
address comment
ciscoxll Sep 4, 2018
f5b9713
update function comment
ciscoxll Sep 5, 2018
9ac506b
update function comment
ciscoxll Sep 5, 2018
29e9f7f
update function comment
ciscoxll Sep 5, 2018
9708292
Merge branch 'master' into bit-default-value
ciscoxll Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update function comment
  • Loading branch information
@ciscoxll
ciscoxll committed Sep 5, 2018
commit 29e9f7fd53f7a637f749782ce607a9bb02494e91
2 changes: 1 addition & 1 deletion model/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func (c *ColumnInfo) SetDefaultValue(value interface{}) error {
if c.Tp == mysql.TypeBit {
// For mysql.TypeBit type, the default value storage format must be a string.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to update the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

// Other value such as int must convert to string format first.
// For mysql.TypeBit type, the default value is null is supported.
// The mysql.TypeBit type supports the null default value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is conflicted with the first sentence of this comment block. Maybe we can merge this two sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winoros This is a special case, it is better to separate comments.

if value == nil {
return nil
}
Expand Down