Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: use point get plan for UPDATE statement #7586

Merged
merged 6 commits into from
Sep 3, 2018
Merged

plan: use point get plan for UPDATE statement #7586

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d804ea
plan: use point get plan for UPDATE statement
coocood Aug 31, 2018
78f4d7b
domain: fix leak test
coocood Sep 3, 2018
6beafe9
simple rewrite supports param marker
coocood Sep 3, 2018
5edbe57
check error
coocood Sep 3, 2018
fc708ee
Merge branch 'master' into point-get-for-update
coocood Sep 3, 2018
8f7e217
Merge branch 'master' into point-get-for-update
ngaut Sep 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check error
  • Loading branch information
@coocood
coocood committed Sep 3, 2018
commit 5edbe57f1b3122ce9943eb9a87580ccffa7f8842
4 changes: 3 additions & 1 deletion plan/point_get_plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,9 @@ func tryUpdatePointPlan(ctx sessionctx.Context, updateStmt *ast.UpdateStmt) Plan
if fastSelect == nil {
return nil
}
checkFastPlanPrivilege(ctx, fastSelect, mysql.SelectPriv, mysql.UpdatePriv)
if checkFastPlanPrivilege(ctx, fastSelect, mysql.SelectPriv, mysql.UpdatePriv) != nil {
return nil
}
orderedList := buildOrderedList(ctx, fastSelect, updateStmt.List)
if orderedList == nil {
return nil
Expand Down