-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: fix show index for the partitioned table #7346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/run-all-tests
The fix is wrong. |
@winkyao @tiancaiamao PTAL. |
ddl/db_test.go
Outdated
for _, pidx := range t.Indices() { | ||
if pidx.Meta().Name.L == "idx1" { | ||
idx1 = pidx | ||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding show index
test case?
Is it the cause of this issue #7308 |
@winkyao @tiancaiamao @zhexuany PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests |
LGTM |
What have you changed? (mandatory)
IndexInfo
from the partition table, but getting theIndexInfo
is always empty.UpdateTable
to update theIndexInfo
.tableCommon
.master branch
show-index branch
What is the type of the changes? (mandatory)
Bug fix
How has this PR been tested? (mandatory)
Unit tests.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Does this PR need to be added to the release notes? (mandatory)
No