*: Tiny clean up #731
Merged
*: Tiny clean up #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ func DecodeValue(data []byte) ([]interface{}, error) { | |||
| } | |||
|
|
|||
| // NextUntil applies FnKeyCmp to each entry of the iterator until meets some condition. | |||
| // It will stop when fn returns true, or iterator is invalid or occur error | |||
| // It will stop when fn returns true, or iterator is invalid or occur error. | |||
There was a problem hiding this comment.
occur error -> occurs errors?
There was a problem hiding this comment.
"error" is the subject and "occur" is the predicate.
occur is an intransitive verb.
| @@ -152,7 +152,7 @@ func (c *kvIndex) GenIndexKey(indexedValues []interface{}, h int64) (key []byte, | |||
| } | |||
|
|
|||
| // Create creates a new entry in the kvIndex data. | |||
| // If the index is unique and there already exists an entry with the same key, Create will return ErrKeyExists | |||
| // If the index is unique and it already existed an entry with the same key, Create will return ErrKeyExists. | |||
There was a problem hiding this comment.
How about there is an existing entry?
|
LGTM |
|
PTAL @siddontang |
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.