ddl, metrics: add worker info to the log #7201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
winkyao
reviewed
Jul 31, 2018
| } | ||
|
|
||
| // start is used for async online schema changing, it will try to become the owner firstly, | ||
| // then wait or pull the job queue to handle a schema change job. | ||
| func (w *worker) start(d *ddlCtx) { | ||
| log.Infof("[ddl] start DDL worker %s", w) | ||
| log.Infof("[ddl-%s] start DDL worker", w) |
There was a problem hiding this comment.
I think keeping the previous format is better. What is the difference?
There was a problem hiding this comment.
[ddl] -> [ddl-worker 0, tp general]
There was a problem hiding this comment.
So what is the problem with the previous log?
There was a problem hiding this comment.
Other places need to add [ddl-worker 0, tp general]. I want to unify the log, so do it.
ciscoxll
reviewed
Aug 2, 2018
| @@ -91,7 +91,7 @@ var ( | |||
| }, []string{LblType, LblResult}) | |||
|
|
|||
| CreateDDLInstance = "create_ddl_instance" | |||
| CreateDDLWorker = "create_ddl_worker" | |||
| CreateDDL = "create_ddl" | |||
|
LGTM |
1 similar comment
|
LGTM |
tiancaiamao
approved these changes
Aug 3, 2018
tiancaiamao
added
status/LGT3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Add worker info to the log.
[ddl] -> [ddl-worker 0, tp general]
What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
No.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Does this PR need to be added to the release notes? (mandatory)
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)