Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix create partition table not suport bit and year column type #7122

Merged
merged 2 commits into from
Jul 23, 2018

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Jul 23, 2018

What have you changed? (mandatory)

TiDB

mysql:test> create TABLE t20 (c1 int,c2 bit(10)) partition by range(c2) (partition p0 values less than (10));
(1105, "Field '`c2`' is of a not allowed type for this type of partitioning")
mysql:test> create TABLE t21 (c1 int,c2 year) partition by range( c2 ) (partition p0 values less than (2000));
(1105, "Field '`c2`' is of a not allowed type for this type of partitioning")

MySQL

mysql:test> create TABLE t20 (c1 int,c2 bit(10)) partition by range(c2) (partition p0 values less than (10));
Query OK, 0 rows affected
Time: 0.014s
mysql:test> create TABLE t21 (c1 int,c2 year) partition by range( c2 ) (partition p0 values less than (2000));
Query OK, 0 rows affected
Time: 0.014s

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Unit Test

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

No

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@crazycs520
Copy link
Contributor Author

@ciscoxll @winkyao @zimulala PTAL

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Jul 23, 2018

@ciscoxll PTAL

@winkyao winkyao added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 23, 2018
@winkyao
Copy link
Contributor

winkyao commented Jul 23, 2018

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-integration-ddl-test
/run-integration-compatibility-test
/run-integration-common-test

@crazycs520
Copy link
Contributor Author

/run-integration-common-test

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 23, 2018
@ciscoxll ciscoxll merged commit 3d04c5e into pingcap:master Jul 23, 2018
@crazycs520 crazycs520 deleted the fix_create_partition_table branch July 23, 2018 08:14
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants