util/kvencoder: use reference count to keep single domain instance #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BootstrapSession should not be called many times and we should keep just a single domain instance
coocood
reviewed
Jul 18, 2018
util/kvencoder/kv_encoder.go
Outdated
| } | ||
|
|
||
| // New new a KvEncoder | ||
| func New(dbName string, idAlloc autoid.Allocator) (KvEncoder, error) { | ||
| kvEnc := &kvEncoder{} | ||
| if atomic.LoadInt64(&refCount) == 0 { |
There was a problem hiding this comment.
Or just hold a lock during initGlobal?
holys
reviewed
Jul 18, 2018
util/kvencoder/kv_encoder.go
Outdated
| } | ||
| if domGlobal != nil { | ||
| domGlobal.Close() | ||
| } | ||
| return nil |
There was a problem hiding this comment.
return error instead of nil?
zz-jason
reviewed
Jul 19, 2018
| @@ -77,27 +78,48 @@ type KvEncoder interface { | |||
| Close() error | |||
| } | |||
|
|
|||
| var ( | |||
| // refCount is used to ensure that there is only one domain.Domain instance. | |||
| refCount int64 | |||
There was a problem hiding this comment.
can we remove refCount? seems we can use domGlobal != nil to replace?
There was a problem hiding this comment.
When refCount decrease to 0, we set domGlobal = nil
There was a problem hiding this comment.
So refCount == 0 is equal to domGolbal == nil?
|
@tiancaiamao Please add some proper labels for this PR. |
|
LGTM |
|
/run-all-tests |
|
LGTM |
holys
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
BootstrapSession should not be called many times and we should keep
just a single domain instance
What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
unit test
@winkyao