planner: remove intest.Assert(ok) that could panic during concurrent DDL#69681
planner: remove intest.Assert(ok) that could panic during concurrent DDL#69681terry1purcell with Copilot wants to merge 2 commits into
Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
What problem does this PR solve?
Issue Number: ref #69676
intest.Assert(ok)inmemtable_infoschema_extractor.gocould panic inintest/enableassertbuilds whenSchemaByIDreturns!ok. This code path is legitimately reachable during concurrent DDL (schema version change between table list and lookup), so the assertion is incorrect and undermines the defensive!okhandling added immediately after it.What changed and how does it work?
pkg/planner/core/memtable_infoschema_extractor.go: Removedintest.Assert(ok)— the!okbranch already handles this case gracefully (logs a warning and continues). Also removed the now-unusedintestimport.Check List
Tests
Side effects
Documentation
Release note