planner: remove intest.Assert on missing schema in memtable infoschema extractor#69678
planner: remove intest.Assert on missing schema in memtable infoschema extractor#69678terry1purcell with Copilot wants to merge 1 commit into
intest.Assert on missing schema in memtable infoschema extractor#69678Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
intest.Assert on missing schema in memtable infoschema extractor
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
What problem does this PR solve?
Problem Summary:
findSchemasForTablesalready handlesSchemaByIDmisses (possible during concurrent DDL), but it still hadintest.Assert(ok)immediately before the defensive branch. Inintest/enableassertbuilds this could still panic, defeating the intended graceful handling.What changed and how does it work?
intest.Assert(ok)inpkg/planner/core/memtable_infoschema_extractor.go.SchemaByIDreturns!ok, the code now consistently follows the existing warning-and-continue path instead of panicking in assert-enabled test builds.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.