Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util:check character set capitalization when creating a table #6914

Merged
merged 2 commits into from
Jun 27, 2018

Conversation

ciscoxll
Copy link
Contributor

@ciscoxll ciscoxll commented Jun 26, 2018

What have you changed? (mandatory)

This pr fix problem check character set capitalization when creating a table.

MySQL [ltest]> create table t5(id int) charset=UTF8;
ERROR 1115 (42000): Unknown character set: 'UTF8'

MySQL [ltest]> create table t5(id int) charset=utf8;
Query OK, 0 rows affected (0.13 sec)

What are the type of the changes (mandatory)?

Bug fix.

How has this PR been tested (mandatory)?

Unit tests.

@ciscoxll
Copy link
Contributor Author

@zimulala @winkyao @shenli PTAL.

@jackysp
Copy link
Member

jackysp commented Jun 26, 2018

Should the title be creating a table?

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 26, 2018
@ciscoxll ciscoxll changed the title util:check character set capitalization when creating a database util:check character set capitalization when creating a table Jun 26, 2018
@ciscoxll
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 27, 2018
@coocood coocood merged commit 1ab7abb into pingcap:master Jun 27, 2018
@ciscoxll ciscoxll deleted the check-charset branch June 27, 2018 03:22
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants