vendor: remove gogo protobuf and update tipb again #6836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
Please fix the CI. |
|
/run-all-tests |
zhexuany
changed the title
|
LGTM |
lysu
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for working on TiDB! Please read TiDB's CONTRIBUTING document BEFORE filing this PR.
What have you changed? (mandatory)
When I tried to generate tipb's side code, I use latest
gogoprotobuf. However, as required, we have to usev0.5. Last PR only regeneratesgo-tipband leavesgo-binlogandgo-mysqlxuntouched. This PR is trying to fix irrelevant code brought by last PR #6825Please explain IN DETAIL what the changes are in this PR and why they are needed:
* update tipb in vendor
How has this PR been tested (mandatory)?
no need to test