Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: admin check table do not use the timezone of session, it leads to false alarm. #6699

Merged
merged 4 commits into from
Jun 4, 2018
Merged

admin: admin check table do not use the timezone of session, it leads to false alarm. #6699

merged 4 commits into from
Jun 4, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented May 30, 2018

admin check table will false alarm in below case:

mysql root@127.0.0.1:test> create table test ( a  TIMESTAMP, primary key(a) );
Query OK, 0 rows affected
Time: 0.129s
mysql root@127.0.0.1:test> insert into test set a='2015-08-10 04:18:49';
Query OK, 1 row affected
Time: 0.119s
mysql root@127.0.0.1:test> select * from test;
+---------------------+
| a                   |
+---------------------+
| 2015-08-10 04:18:49 |
+---------------------+
1 row in set
Time: 0.007s
mysql root@127.0.0.1:test> admin check table test;
(1105, 'test err:[admin:1]index:&{1 [{2 0 0 0 1843893389435600896 [] <nil>}]} != record:&{1 [{13 0 0 0 1843893389435600896 [] {{2015 8 9 20 18 49 0} 7 0}}]}')
mysql root@127.0.0.1:test>

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2018
@shenli
Copy link
Member

shenli commented Jun 1, 2018

LGTM

@shenli
Copy link
Member

shenli commented Jun 1, 2018

/run-all-tests

@shenli shenli added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2018
@winkyao
Copy link
Contributor Author

winkyao commented Jun 1, 2018

/run-unit-test

@winkyao
Copy link
Contributor Author

winkyao commented Jun 4, 2018

/run-unit-test

@winkyao
Copy link
Contributor Author

winkyao commented Jun 4, 2018

/run-all-tests

@winkyao winkyao merged commit 64e3aca into pingcap:master Jun 4, 2018
@winkyao winkyao deleted the fix_admin_check_table_timezone branch June 4, 2018 06:14
shenli pushed a commit that referenced this pull request Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants