util/traceevent: make flaky test TestFlightRecorder stable (#65317)#65351
util/traceevent: make flaky test TestFlightRecorder stable (#65317)#65351ti-chi-bot wants to merge 1 commit intopingcap:release-8.5from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This is an automated cherry-pick of #65317
What problem does this PR solve?
Issue Number: close #65230
Problem Summary:
What changed and how does it work?
The test use global variable
IsEnabled(category)and other tests also update that variable, so the test is unstable.I just moving category to
GetFlightRecorder().enabledCategoriesto avoid conflict, no other tests in this package are updating the same FlightRecorder structure at the same time.This PR just fix the flaky test, later I should do some refactor.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.